linux-kernel - Re: [PATCH] media: dw100: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a13acbeb-e545-9e8e-40f9-b02526b867b8@oss.nxp.com>
Date:   Wed, 8 Feb 2023 11:12:08 +0100
From:   "Xavier Roumegue (OSS)" <xavier.roumegue@....nxp.com>
To:     ye.xingchen@....com.cn
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: dw100: use
 devm_platform_get_and_ioremap_resource()

Hi Ye Xingchen,

Thanks for your patch.

On 2/8/23 09:35, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Reviewed-by: Xavier Roumegue <xavier.roumegue@....nxp.com>

Regards,
  Xavier

> ---
>   drivers/media/platform/nxp/dw100/dw100.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index 189d60cd5ed1..0771a88122c0 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
>   {
>   	struct dw100_device *dw_dev;
>   	struct video_device *vfd;
> -	struct resource *res;
>   	int ret, irq;
> 
>   	dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
> @@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
>   	}
>   	dw_dev->num_clks = ret;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> +	dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>   	if (IS_ERR(dw_dev->mmio))
>   		return PTR_ERR(dw_dev->mmio);
>