linux-kernel - Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0496ff17-0a02-1192-3c9a-412656a38b6a@gmail.com>
Date:   Wed, 8 Feb 2023 11:25:36 +0100
From:   Rafał Miłecki <zajec5@...il.com>
To:     Willem-Jan de Hoog <wdehoog@...londelft.nl>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     Rafał Miłecki <rafal@...ecki.pl>,
        Arınç ÜNAL <arinc.unal@...nc9.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] nvmem: brcm_nvram: use bcm47xx buffered data

On 7.02.2023 09:42, Willem-Jan de Hoog wrote:
> From: Willem-Jan de Hoog <wdehoog@...londelft.nl>
> 
> The bcm47xx module has a copy of the NVRAM data in ram. When available, use
> this one instead of reading from io memory since it causes mtd/ubi to fail.

This doesn't explain anything. Why do we need that? If anything we
should rather get rid of that NVRAM firmware driver. It was needed
before we had all NVMEM stuff in place. Finally how can reading
iomem break mtd/ubi?!

It seems like some hack instead of proper fix. Possibly because of lack
of understanding the issue / some subsystem.