linux-kernel - Re: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx() when available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <e09b458a-32bf-46aa-b509-a383e34d4888@app.fastmail.com>
Date:   Wed, 08 Feb 2023 11:39:23 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "chris.chenfeiyang" <chris.chenfeiyang@...il.com>,
        "Willy Tarreau" <w@....eu>, "Paul E. McKenney" <paulmck@...nel.org>
Cc:     "Feiyang Chen" <chenfeiyang@...ngson.cn>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] tools/nolibc: Add statx() and make stat() rely on statx()
 when available

On Wed, Feb 8, 2023, at 11:17, chris.chenfeiyang@...il.com wrote:
> From: Feiyang Chen <chenfeiyang@...ngson.cn>
>
> loongarch and riscv32 only have statx(). arc, hexagon, nios2 and
> openrisc have statx() and stat64() but not stat() or newstat().
> Add statx() and make stat() rely on statx() to make them happy.

> +#ifdef __NR_statx
> +static __attribute__((unused))
> +int sys_stat(const char *path, struct stat *buf)
> +{

The actual #ifdef check here does what I had suggested first, using
statx() for all architectures, rather than what you describe in the
changelog. I think you should keep the check from the first version,
testing for __NR_stat/__NR_newfstatat and keep the changelog text
here. Also please add something about the possibility of using statx()
everywhere in the future.

      Arnd