linux-kernel - Re: [PATCH v1 1/1] media: i2c: imx290: Use device_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+O/ZbAa3zu1nSI0@pendragon.ideasonboard.com>
Date:   Wed, 8 Feb 2023 17:27:33 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Manivannan Sadhasivam <mani@...nel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: i2c: imx290: Use
 device_property_read_u32() directly

Hi Andy,

Thank you for the patch.

On Wed, Feb 08, 2023 at 01:33:48PM +0200, Andy Shevchenko wrote:
> No need to call fwnode_property_read_u32(dev_fwnode()), when
> we have already existing helper. So use it.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/media/i2c/imx290.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 330098a0772d..e7aa2ecdcc88 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -1137,8 +1137,7 @@ static int imx290_init_clk(struct imx290 *imx290)
>  	u32 xclk_freq;
>  	int ret;
>  
> -	ret = fwnode_property_read_u32(dev_fwnode(imx290->dev),
> -				       "clock-frequency", &xclk_freq);
> +	ret = device_property_read_u32(imx290->dev, "clock-frequency", &xclk_freq);

I'd break the line here.

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

>  	if (ret) {
>  		dev_err(imx290->dev, "Could not get xclk frequency\n");
>  		return ret;

-- 
Regards,

Laurent Pinchart