linux-kernel - Re: [PATCH v8 11/11] arm64: dts: qcom: sm8550: Fix PCIe PHYs and controllers nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Feb 2023 18:02:43 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Abel Vesa <abel.vesa@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 11/11] arm64: dts: qcom: sm8550: Fix PCIe PHYs and
 controllers nodes

On Mon, Feb 06, 2023 at 11:26:19PM +0200, Abel Vesa wrote:
> First, move the pinctrl related propeties out from SoC dtsi and into the
> board dts and add blank lines before status properties in the PHY nodes
> to be consistent with the rest of the nodes. Then drop the pipe clock
> from the controller nodes. Rename the aggre0 and aggre1 clocks to more
> generic noc_aggr. Add the cpu-pcie interconnects to both controller nodes.
> Rename the pcie1 second reset to link_down and drop the unnecessary
> enable-gpios. Switch the aux clock to GCC_PCIE_1_PHY_AUX_CLK for the pcie1
> PHY and drop the aux_phy from clock-names. Also rename the nocsr reset to
> phy_nocsr. With this changes we are now in line with the SC8280XP bindings.
> 
> Fixes: 98a4dc3a78fa ("arm64: dts: qcom: sm8550: Add PCIe PHYs and controllers nodes")
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
> 
> This time, this patch actually fixes the already merged PCIe related
> nodes. When compared to the earlier version of this patchset, this patch
> leads to the PCIe nodes looking the same. Sorry for all this mess.

Looks good now. 

Reviewed-by: Johan Hovold <johan+linaro@...nel.org>