linux-kernel - RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP mode support for ls1028a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR0401MB23314DE22C95A53D63946B0F88D99@HE1PR0401MB2331.eurprd04.prod.outlook.com>
Date:   Thu, 9 Feb 2023 15:12:35 +0000
From:   Frank Li <frank.li@....com>
To:     ALOK TIWARI <alok.a.tiwari@...cle.com>,
        Bjorn Helgaas <helgaas@...nel.org>
CC:     "M.H. Lian" <minghuan.lian@....com>,
        Mingkai Hu <mingkai.hu@....com>, Roy Zang <roy.zang@....com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linuxppc-dev@...ts.ozlabs.org>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-pci@...r.kernel.org>,
        "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: RE: [External] : RE: [EXT] [PATCH v2 1/1] PCI: layerscape: Add EP
 mode support for ls1028a


> 
> Caution: EXT Email
> 
> yes, it is more about sort the list using .data and .compatible. key
> 
> much better if it we keep this as suggested by Frank,
> 
>   static const struct of_device_id ls_pcie_ep_of_match[] = {
> +       { .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>          { .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>          { .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },

Thanks, v3 sent.
Frank Li
> 
> 
> 
> Thanks,
> 
> Alok