linux-kernel - Re: [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f73477e9-b27a-8cc7-dfe9-7208b3522083@linux.intel.com>
Date:   Thu, 9 Feb 2023 09:15:03 -0600
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>,
        Zhang Yiqun <zhangyiqun@...tium.com.cn>
Cc:     cezary.rojewski@...el.com, liam.r.girdwood@...ux.intel.com,
        peter.ujfalusi@...ux.intel.com, yung-chuan.liao@...ux.intel.com,
        ranjani.sridharan@...ux.intel.com, kai.vehmanen@...ux.intel.com,
        tiwai@...e.com, amadeuszx.slawinski@...ux.intel.com,
        kuninori.morimoto.gx@...esas.com, ckeepax@...nsource.cirrus.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: remove redundant variable in
 snd_hdac_stream_start()



On 2/9/23 08:32, Mark Brown wrote:
> On Thu, Feb 09, 2023 at 08:17:23PM +0800, Zhang Yiqun wrote:
>> This 2nd variables are all set as true in treewide. So I think
>> it can be removed for easy understanding.
> 
> Acked-by: Mark Brown <broonie@...nel.org>

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>

Btw there's another type of always-true parameter, we have a full_reset
parameter that's not used.

sound/soc/intel/skylake$ git grep  skl_init_chip
skl.c:static int skl_init_chip(struct hdac_bus *bus, bool full_reset)
skl.c:  skl_init_chip(bus, true);
skl.c:                          skl_init_chip(bus, true);
skl.c:  err = skl_init_chip(bus, true);

sound/soc/intel/avs$ git grep  init_chip
core.c:static bool avs_hdac_bus_init_chip(struct hdac_bus *bus, bool
full_reset)
core.c: ret = snd_hdac_bus_init_chip(bus, full_reset);
core.c:         avs_hdac_bus_init_chip(bus, true);
core.c: avs_hdac_bus_init_chip(bus, true);
core.c: avs_hdac_bus_init_chip(bus, true);