linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <757804b7-8a63-db1c-afab-3c0c1a602807@kernel.org>
Date:   Thu, 9 Feb 2023 17:00:03 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org
Cc:     agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        linux-kernel@...r.kernel.org, bhupesh.linux@...il.com,
        robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for
 qup0

On 09/02/2023 16:11, Krzysztof Kozlowski wrote:
> On 08/02/2023 13:27, Bhupesh Sharma wrote:
>> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
>> Add the debug uart node in sm6115 dtsi file.
>>
>> Cc: Bjorn Andersson <andersson@...nel.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
>> ---
>>  Changes since v1:
>>   - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
>>   - Addressed Konrad's review comments on v1.
>>   - Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
>>     already in the dtsi file, so just add the debug uart node in v2.
>>
>>  arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> index 50cb8a82ecd5..3eccfb8c16ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> @@ -963,6 +963,15 @@ spi4: spi@...0000 {
>>  				status = "disabled";
>>  			};
>>  
>> +			uart4: serial@...0000 {
>> +				compatible = "qcom,geni-debug-uart";
>> +				reg = <0x04a90000 0x4000>;
>> +				clock-names = "se";
>> +				clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
>> +				interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
>> +				status = "disabled";
>> +			};
>> +
>>  			i2c5: i2c@...4000 {
>>  				compatible = "qcom,geni-i2c";
>>  				reg = <0x04a94000 0x4000>;
>> @@ -992,7 +1001,6 @@ spi5: spi@...4000 {
>>  				dma-names = "tx", "rx";
>>  				#address-cells = <1>;
>>  				#size-cells = <0>;
>> -				status = "disabled";
> 
> Why do you enable SPI? The commit msg is not explaining it.

Sent fixup:
https://lore.kernel.org/linux-arm-msm/20230209155831.100066-1-krzysztof.kozlowski@linaro.org/T/#u

Best regards,
Krzysztof