linux-kernel - Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 09 Feb 2023 17:46:48 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        ~postmarketos/upstreaming@...ts.sr.ht,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-media@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org,
        Shunqian Zheng <zhengsq@...k-chips.com>,
        phone-devel@...r.kernel.org,
        Helen Koike <helen.koike@...labora.com>
Subject: Re: [PATCH] media: dt-bindings: ov2685: convert to dtschema

+CC Helen Koike

On Montag, 6. Februar 2023 22:50:08 CET Rob Herring wrote:
> On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote:
> > Convert the text-based dt-bindings to yaml.
> > 
> > Changes from original txt:
> > * Take wording for various properties from other yaml bindings, this
> > 
> >   removes e.g. volt amount from schema since it isn't really relevant
> >   and the datasheet is a better source.
> > 
> > * Don't make reset-gpios a required property since it can be tied to
> > 
> >   DOVDD instead.
> > 
> > Signed-off-by: Luca Weiss <luca@...tu.xyz>
> > ---
> > 
> >  .../devicetree/bindings/media/i2c/ov2685.txt       |  41 ---------
> >  .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101
> >  +++++++++++++++++++++ MAINTAINERS                                       
> >  |   1 +
> >  3 files changed, 102 insertions(+), 41 deletions(-)
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/medi
> a/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required property From
> schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required
> property From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required
> property From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required
> property From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required
> property From schema:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/med
> ia/i2c/ovti,ov2685.yaml

Looks like rockchip-isp1.yaml uses very incomplete sensor examples in their 
binding example, which sort of makes sense since those bindings are showing 
the rockchip isp bindings and contain the bare minimum to show how a sensor is 
connected in dt.

Not sure how to solve this - ov2685 is also one of three sensors that are used 
very abbreviated there.

Regards
Luca

> 
> doc reference errors (make refcheckdocs):
> 
> See
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230206-ov2
> 685-dtschema-v1-1-9e4da3474c10@...tu.xyz
> 
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
> 
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> 
> pip3 install dtschema --upgrade
> 
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your
> schema.