linux-kernel - Re: [PATCH v3] iommu/vt-d: Fix PASID directory pointer coherency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230209090603.37854cb9@jacob-builder>
Date:   Thu, 9 Feb 2023 09:06:03 -0800
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Liu, Yi L" <yi.l.liu@...el.com>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Ghorai, Sukumar" <sukumar.ghorai@...el.com>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v3] iommu/vt-d: Fix PASID directory pointer coherency

Hi Kevin,

On Thu, 9 Feb 2023 02:08:23 +0000, "Tian, Kevin" <kevin.tian@...el.com>
wrote:

> > @@ -1976,6 +1976,8 @@ static int domain_context_mapping_one(struct
> > dmar_domain *domain,
> >  		pds = context_get_sm_pds(table);
> >  		context->lo = (u64)virt_to_phys(table->table) |
> >  				context_pdts(pds);
> > +		if (!ecap_coherent(iommu->ecap))
> > +			clflush_cache_range(table->table,
> > sizeof(u64));  
> 
> this is not required if cache is already flushed when the table is
> allocated.
yes you're right.

Thanks,

Jacob