linux-kernel - Re: [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 09:37:59 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     ye.xingchen@....com.cn
Cc:     nick.hawkins@....com, verdun@....com, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource()

On Wed, Feb 08, 2023 at 03:46:06PM +0800, ye.xingchen@....com.cn wrote:
> From: Ye Xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Ye Xingchen <ye.xingchen@....com.cn>

Applied to hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/gxp-fan-ctrl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/hwmon/gxp-fan-ctrl.c b/drivers/hwmon/gxp-fan-ctrl.c
> index 0e9225a8b805..0014b8b0fd41 100644
> --- a/drivers/hwmon/gxp-fan-ctrl.c
> +++ b/drivers/hwmon/gxp-fan-ctrl.c
> @@ -199,7 +199,6 @@ static const struct hwmon_chip_info gxp_fan_ctrl_chip_info = {
>  static int gxp_fan_ctrl_probe(struct platform_device *pdev)
>  {
>  	struct gxp_fan_ctrl_drvdata *drvdata;
> -	struct resource *res;
>  	struct device *dev = &pdev->dev;
>  	struct device *hwmon_dev;
> 
> @@ -208,8 +207,7 @@ static int gxp_fan_ctrl_probe(struct platform_device *pdev)
>  	if (!drvdata)
>  		return -ENOMEM;
> 
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	drvdata->base = devm_ioremap_resource(&pdev->dev, res);
> +	drvdata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
>  	if (IS_ERR(drvdata->base))
>  		return dev_err_probe(dev, PTR_ERR(drvdata->base),
>  				     "failed to map base\n");