linux-kernel - Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet 3 10IGL5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 17:59:15 +0000
From:   Darrell Kavanagh <darrell.kavanagh@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Maxime Ripard <maxime@...no.tech>,
        maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
        airlied@...il.com, daniel@...ll.ch,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: drm: panel-orientation-quirks: Add quirk for Lenovo IdeaPad Duet
 3 10IGL5

It certainly is a learning process! Let me try to get things together
properly myself, will be useful in the long run.

Darrell

On Thu, 9 Feb 2023 at 15:53, Hans de Goede <hdegoede@...hat.com> wrote:
>
> Hi,
>
> On 2/9/23 16:36, Maxime Ripard wrote:
> > Hi,
> >
> > On Wed, Feb 08, 2023 at 07:04:58PM +0000, Darrell Kavanagh wrote:
> >> I've resolved this by adding a matching quirk in
> >> drivers/firmware/efi/sysfb_efi.c - see below.
>
> Right, this is a known issue on Lenovo 2-in-1s with
> the panel mounted 90 degree rotated issue. For some reason
> the efifb info still gives a landscape resolution even though
> the actual resolution really is portrait. This also messes
> up the pitch of the framebuffer leading to the weird corrupted
> looking output you saw.
>
> >> I've resolved this by adding a matching quirk in
> >> drivers/firmware/efi/sysfb_efi.c - see below.
> >>
> >> Are you the right people to be notifying about this?
> >
> > Yes, we are.
> >
> > Howewer, please follow
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > In particular, a proper commit log and your Signed-off-By tag is missing.
>
> Are we, do patches to that file go through drm-misc ?  :
>
> [hans@...lem linux]$ scripts/get_maintainer.pl -f drivers/firmware/efi/sysfb_efi.c
> Ard Biesheuvel <ardb@...nel.org> (maintainer:EXTENSIBLE FIRMWARE INTERFACE (EFI))
> linux-efi@...r.kernel.org (open list:EXTENSIBLE FIRMWARE INTERFACE (EFI))
> linux-kernel@...r.kernel.org (open list)
>
> Either way this should be turned into a proper patch with a proper
> Signed-off-By message as Maxime mentioned.
>
> My offer for the drm_panel_orientation_quirks.c patch to turn it into
> a proper patch for you also extends to this one. If you want that,
> please let me know and again add your Signed-off-by as a standalone
> separate line in your reply so that I can use it for the commit message.
>
> Regards,
>
> Hans
>
>