linux-kernel - Re: [PATCH v2 6/6] selftests: Test the new RISC-V hwprobe interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs-HsvQiRm-guFMy-E4J+CTLoOMoxb=JiedbtFrdXwzz-oSoA@mail.gmail.com>
Date:   Thu, 9 Feb 2023 10:44:36 -0800
From:   Evan Green <evan@...osinc.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Palmer Dabbelt <palmer@...osinc.com>,
        Conor Dooley <conor@...nel.org>, vineetg@...osinc.com,
        heiko@...ech.de, slewis@...osinc.com,
        Albert Ou <aou@...s.berkeley.edu>,
        Catalin Marinas <catalin.marinas@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v2 6/6] selftests: Test the new RISC-V hwprobe interface

On Mon, Feb 6, 2023 at 1:27 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Mon, Feb 06, 2023 at 12:14:55PM -0800, Evan Green wrote:
>
> > +int main(int argc, char **argv)
> > +{
>
> > --- /dev/null
> > +++ b/tools/testing/selftests/riscv/libc.S
>
> > +.global _start
> > +_start:
> > +.option push
> > +.option norelax
> > +     la gp, __global_pointer$
> > +.option pop
> > +
> > +     la sp, stack
> > +
> > +     la t0, heap
> > +     la t1, brk
> > +     REG_S t0, 0(t1)
> > +
> > +     li a0, 0
> > +     li a1, 0
> > +
> > +     call main
>
> This looks like it's just a standard program entry but I don't speak
> RISC-V asm so I might be missing something.  If that's the case might it
> make sense to use nolibc here?

I think I can just remove this file entirely along with -nostdlib, and
just let the compiler add in this glue.
-Evan