linux-kernel - Re: [PATCH v3 0/5] Add LoongArch support to nolibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H4-m3AaS4-w-+yyUwBMt8Fm30SkS7ZnfSL5zA1OzJsLTA@mail.gmail.com>
Date:   Thu, 9 Feb 2023 11:38:02 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Willy Tarreau <w@....eu>
Cc:     chris.chenfeiyang@...il.com, paulmck@...nel.org,
        Feiyang Chen <chenfeiyang@...ngson.cn>, arnd@...db.de,
        jiaxun.yang@...goat.com, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/5] Add LoongArch support to nolibc

Acked-by: Huacai Chen <chenhuacai@...ngson.cn>

On Thu, Feb 9, 2023 at 11:35 AM Willy Tarreau <w@....eu> wrote:
>
> Hi Feiyang,
>
> On Thu, Feb 09, 2023 at 11:24:11AM +0800, chris.chenfeiyang@...il.com wrote:
> > From: Feiyang Chen <chenfeiyang@...ngson.cn>
> >
> > Add statx() and make stat() rely on statx() if necessary.
> > Add support for LoongArch (32 and 64 bit) to nolibc.
> > It was tested on LoongArch64 only.
> >
> > The latest QEMU support full-system emulation of a LoongArch64
> > machine, but for the moment we need to specify the firmware manually.
> > https://github.com/loongson/Firmware/tree/main/LoongArchVirtMachine
> >
> > QEMU_ARGS_loongarch  = -M virt -bios edk2-loongarch64-code.fd ...
> >
> > v2:
> > - Mention that statx() will also benefit other architectures.
> > - Make stat() rely on statx() when available.
> > - Put the whitespace changes into one commit.
> >
> > v3:
> > - Add #if defined(__NR_statx) guard.
> > - Keep the check for statx() from the first version.
> > - Mention that we may use statx() everywhere in the future.
> > - struct statx stat -> struct statx statx.
>
> I'm personally fine with this one. I'll give it a try with all supported
> archs to make sure we don't have any unexpected side effect, and unless
> anyone has any other comment, we'll queue this series.
>
> Thank you!
> Willy