linux-kernel - Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 23:42:59 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <oder_chiou@...ltek.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <lgirdwood@...il.com>,
        <devicetree@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <alsa-devel@...a-project.org>
Subject: Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk()


Hi Sameer

> Simple-card/audio-graph-card drivers do not handle MCLK clock when it
> is specified in the codec device node. The expectation here is that,
> the codec should actually own up the MCLK clock and do necessary setup
> in the driver.

I have no objection about this patch, but have interesting about this comment.

Simple-card/audio-graph-card both are using asoc_simple_hw_params,
and it calls clk_set_rate() for Codec/CPU if it has mclk.
But am I misunderstanding ?
If it was simple-card-utils side miss, I'm happy to fix it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto