linux-kernel - Re: [PATCH] platform/x86: int3472/discrete: add LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+S4qZAQf6LAT16s@kekkonen.localdomain>
Date:   Thu, 9 Feb 2023 11:11:05 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Daniel Scally <djrscally@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: int3472/discrete: add LEDS_CLASS dependency

On Wed, Feb 08, 2023 at 05:36:52PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> int3472 now fails to link when the LED support is disabled:
> 
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_register_pled':
> led.c:(.text+0xf4): undefined reference to `led_classdev_register_ext'
> x86_64-linux-ld: led.c:(.text+0x131): undefined reference to `led_add_lookup'
> x86_64-linux-ld: drivers/platform/x86/intel/int3472/led.o: in function `skl_int3472_unregister_pled':
> led.c:(.text+0x16b): undefined reference to `led_remove_lookup'
> x86_64-linux-ld: led.c:(.text+0x177): undefined reference to `led_classdev_unregister'
> 
> Add an explicit Kconfig dependency.
> 
> Fixes: 5ae20a8050d0 ("platform/x86: int3472/discrete: Create a LED class device for the privacy LED")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus