linux-kernel - Re: [PATCH 2/5] crypto: hisilicon/qm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+S9kS8cElGRGysn@gondor.apana.org.au>
Date:   Thu, 9 Feb 2023 17:32:01 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Weili Qian <qianweili@...wei.com>
Cc:     linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        wangzhou1@...ilicon.com, liulongfang@...wei.com
Subject: Re: [PATCH 2/5] crypto: hisilicon/qm - change data type in min_t

On Fri, Feb 03, 2023 at 05:37:27PM +0800, Weili Qian wrote:
> 'act_q_num = min_t(int, act_q_num, max_qp_num)', 'act_q_num'
> and 'max_qp_num' are 'u32' type, change min_t() to use 'u32'
> type instead of 'int'.

If they are of the same type, why not just do min?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt