linux-kernel - Re: [PATCH] irq: ipi: fix NULL pointer deref in irq_data_get_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875ycb2jwe.ffs@tglx>
Date:   Thu, 09 Feb 2023 11:49:37 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Sergey Shtylyov <s.shtylyov@....ru>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: ipi: fix NULL pointer deref in
 irq_data_get_affinity_mask()

On Wed, Feb 08 2023 at 21:35, Sergey Shtylyov wrote:
> On 8/17/22 11:00 PM, Sergey Shtylyov wrote:
>
>> Iff ipi_send_{mask|single}() get called with e.g. an invalid IRQ #, all the
>> local variables there will be NULL -- the problem is that ipi_send_verify()
>> (that's called first thing) doesn't verify its 'data' parameter, resulting
>> in a kernel oops in irq_data_get_affinity_mask() as the passed NULL pointer
>> gets dereferenced.  Add a missing NULL check in ipi_send_verify()...
>> 
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>> 
>> Fixes: 3b8e29a82dd1 ("genirq: Implement ipi_send_mask/single()")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@....ru>
>
>    Patch fell thru the cracks? :-/

Obviously :)

/me goes to find trash tongs to pick it up