linux-kernel - [PATCH 3/7] blk-mq: remove wake_batch recalculation for reserved tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2023 04:11:12 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     axboe@...nel.dk, hch@....de, jack@...e.cz
Cc:     andriy.shevchenko@...ux.intel.com, qiulaibin@...wei.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 3/7] blk-mq: remove wake_batch recalculation for reserved tags

Commit 180dccb0dba4f ("blk-mq: fix tag_get wait task can't be
awakened") added wake_batch recalculation when user number of shared
tags changes to avoid hung as user number increases, then hctx_max_depth
limit for a single user decreases and may trigger hung if wake_batch >
hctx_max_depth is met.
Commit 285008501c65a ("blk-mq: always allow reserved allocation in
hctx_may_queue") removed hctx_max_depth limit to alloc reserved
tags, so hctx_max_depth limit for reserved tags is not exisiting anymore
so we can remove recalculation for reserved tags.

Fixes: 285008501c65 ("blk-mq: always allow reserved allocation in hctx_may_queue")
Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
---
 block/blk-mq-tag.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c
index e566fd96dc26..7f1777dc11e5 100644
--- a/block/blk-mq-tag.c
+++ b/block/blk-mq-tag.c
@@ -27,8 +27,6 @@ static void blk_mq_update_wake_batch(struct blk_mq_tags *tags,

 	sbitmap_queue_recalculate_wake_batch(&tags->bitmap_tags,
 			users);
-	sbitmap_queue_recalculate_wake_batch(&tags->breserved_tags,
-			users);
 }

 /*
-- 
2.30.0