linux-kernel - Re: [PATCH] m68k: /proc/hardware depends on PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 9 Feb 2023 14:54:39 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...ux-m68k.org>,
        linux-m68k@...ts.linux-m68k.org, uclinux-dev@...inux.org
Subject: Re: [PATCH] m68k: /proc/hardware depends on PROC_FS

Hi Randy,

On Thu, Feb 9, 2023 at 2:08 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> When CONFIG_PROC_FS is not set, there is a build error for an unused
> function. Make PROC_HARDWARE depend on PROC_FS to prevent this error.
>
> In file included from ../arch/m68k/kernel/setup.c:3:
> ../arch/m68k/kernel/setup_mm.c:477:12: error: 'hardware_proc_show' defined but not used [-Werror=unused-function]
>   477 | static int hardware_proc_show(struct seq_file *m, void *v)
>       |            ^~~~~~~~~~~~~~~~~~
>
> Fixes: 66d857b08b8c ("m68k: merge m68k and m68knommu arch directories") # v3.0
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

Thanks for your patch!

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k for-v6.3 branch.

> --- a/arch/m68k/Kconfig.devices
> +++ b/arch/m68k/Kconfig.devices
> @@ -18,6 +18,7 @@ config HEARTBEAT
>
>  # We have a dedicated heartbeat LED. :-)
>  config PROC_HARDWARE
> +       depends on PROC_FS

I'll move the "depends ..." line below the "bool ..." line while applying,
as that's where the dependencies are usually listed.

>         bool "/proc/hardware support"
>         help
>           Say Y here to support the /proc/hardware file, which gives you

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds