linux-kernel - Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_Pju2QxoR2QEhWf_p9EcKnuF+SkqaKJ7i7adxBktJBBAw@mail.gmail.com>
Date:   Thu, 9 Feb 2023 09:35:41 -0500
From:   Alex Deucher <alexdeucher@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Xinhui.Pan@....com, David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function
 name in error message

Applied.  Thanks!

Alex

On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King <colin.i.king@...il.com> wrote:
>
> The function name is being reported as dc_link_contruct when it is
> actually dc_link_construct_phy. Fix this by using %s and the __func__
> for the function name.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> index 13a766273755..3fc93fc593fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> @@ -452,7 +452,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
>         link->psr_settings.psr_vtotal_control_support = false;
>         link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>
> -       DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> +       DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
>         return true;
>  device_tag_fail:
>         link->link_enc->funcs->destroy(&link->link_enc);
> @@ -469,7 +469,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
>                 link->hpd_gpio = NULL;
>         }
>
> -       DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> +       DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
>         return false;
>  }
>
> --
> 2.30.2
>