| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230210210804.vdyfrog5nq6hrxi5@skbuf>
Date: Fri, 10 Feb 2023 23:08:04 +0200
From: Vladimir Oltean <vladimir.oltean@....com>
To: Saravana Kannan <saravanak@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Sudeep Holla <sudeep.holla@....com>,
Cristian Marussi <cristian.marussi@....com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Thomas Gleixner <tglx@...utronix.de>,
Marc Zyngier <maz@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Magnus Damm <magnus.damm@...il.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Daniel Scally <djrscally@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Len Brown <lenb@...nel.org>,
Rafał Miłecki <rafal@...ecki.pl>,
Abel Vesa <abel.vesa@...aro.org>,
Alexander Stein <alexander.stein@...tq-group.com>,
Tony Lindgren <tony@...mide.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>,
John Stultz <jstultz@...gle.com>,
Doug Anderson <dianders@...omium.org>,
Guenter Roeck <linux@...ck-us.net>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Maxim Kiselev <bigunclemax@...il.com>,
Maxim Kochetkov <fido_max@...ox.ru>,
Luca Weiss <luca.weiss@...rphone.com>,
Colin Foster <colin.foster@...advantage.com>,
Martin Kepplinger <martin.kepplinger@...i.sm>,
Jean-Philippe Brucker <jpb@...nel.org>,
kernel-team@...roid.com, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org,
linux-renesas-soc@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v3 00/12] fw_devlink improvements
On Fri, Feb 10, 2023 at 11:27:11AM -0800, Saravana Kannan wrote:
> On Fri, Feb 10, 2023 at 2:13 AM Vladimir Oltean <vladimir.oltean@....com> wrote:
> >
> > Hi Saravana,
> >
> > On Mon, Feb 06, 2023 at 05:41:52PM -0800, Saravana Kannan wrote:
> > > Vladimir,
> > >
> > > Ccing you because DSA's and fw_devlink have known/existing problems
> > > (still in my TODOs to fix). But I want to make sure this series doesn't
> > > cause additional problems for DSA.
> > >
> > > All,
> > >
> > > This patch series improves fw_devlink in the following ways:
> > >
> > > 1. It no longer cares about a fwnode having a "compatible" property. It
> > > figures this out more dynamically. The only expectation is that
> > > fwnodes that are converted to devices actually get probed by a driver
> > > for the dependencies to be enforced correctly.
> > >
> > > 2. Finer grained dependency tracking. fw_devlink will now create device
> > > links from the consumer to the actual resource's device (if it has one,
> > > Eg: gpio_device) instead of the parent supplier device. This improves
> > > things like async suspend/resume ordering, potentially remove the need
> > > for frameworks to create device links, more parallelized async probing,
> > > and better sync_state() tracking.
> > >
> > > 3. Handle hardware/software quirks where a child firmware node gets
> > > populated as a device before its parent firmware node AND actually
> > > supplies a non-optional resource to the parent firmware node's
> > > device.
> > >
> > > 4. Way more robust at cycle handling (see patch for the insane cases).
> > >
> > > 5. Stops depending on OF_POPULATED to figure out some corner cases.
> > >
> > > 6. Simplifies the work that needs to be done by the firmware specific
> > > code.
> > >
> > > The v3 series has gone through my usual testing on my end and looks good
> > > to me.
> >
> > Booted on an NXP LS1028A (arch/arm64/boot/dts/freescale/fsl-ls1028a-rdb.dts)
> > and a Turris MOX (arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts)
> > with no observed regressions.
>
> Thanks for testing Vladimir!
>
> > Is there something specific you would like
> > me to test?
>
> Not really, I just want to make sure the common DSA architectures
> don't hit any regression. In the hardware you tested, are there cases
> of PHYs where the supplier is the parent MDIO? I remember that being
> the only case where I needed special casing
> (FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD) in fw_devlink -- so it'll be
> good to make sure I didn't accidentally break anything there.
>
> -Saravana
Yes and no (I never had a system which depended on FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD).
Yes, because well, yes, in arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts,
the PHYs will depend on interrupts provided by their (parent) switch. However this
is not explicit in the device tree. To make it explicit, one would need to add:
diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
index cd0988317623..d789cda49e35 100644
--- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
+++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts
@@ -305,12 +305,14 @@ phy1: ethernet-phy@1 {
};
/* switch nodes are enabled by U-Boot if modules are present */
- switch0@10 {
+ switch0_peridot: switch0@10 {
compatible = "marvell,mv88e6190";
reg = <0x10>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(0)>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -319,34 +321,42 @@ mdio {
switch0phy1: switch0phy1@1 {
reg = <0x1>;
+ interrupts-extended = <&switch0_peridot 1 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy2: switch0phy2@2 {
reg = <0x2>;
+ interrupts-extended = <&switch0_peridot 2 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy3: switch0phy3@3 {
reg = <0x3>;
+ interrupts-extended = <&switch0_peridot 3 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy4: switch0phy4@4 {
reg = <0x4>;
+ interrupts-extended = <&switch0_peridot 4 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy5: switch0phy5@5 {
reg = <0x5>;
+ interrupts-extended = <&switch0_peridot 5 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy6: switch0phy6@6 {
reg = <0x6>;
+ interrupts-extended = <&switch0_peridot 6 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy7: switch0phy7@7 {
reg = <0x7>;
+ interrupts-extended = <&switch0_peridot 7 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy8: switch0phy8@8 {
reg = <0x8>;
+ interrupts-extended = <&switch0_peridot 8 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -430,12 +440,14 @@ port-sfp@a {
};
};
- switch0@2 {
+ switch0_topaz: switch0@2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
dsa,member = <0 0>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -444,18 +456,22 @@ mdio {
switch0phy1_topaz: switch0phy1@11 {
reg = <0x11>;
+ interrupts-extended = <&switch0_topaz 0x11 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy2_topaz: switch0phy2@12 {
reg = <0x12>;
+ interrupts-extended = <&switch0_topaz 0x12 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy3_topaz: switch0phy3@13 {
reg = <0x13>;
+ interrupts-extended = <&switch0_topaz 0x13 IRQ_TYPE_LEVEL_HIGH>;
};
switch0phy4_topaz: switch0phy4@14 {
reg = <0x14>;
+ interrupts-extended = <&switch0_topaz 0x14 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -497,12 +513,14 @@ port@5 {
};
};
- switch1@11 {
+ switch1_peridot: switch1@11 {
compatible = "marvell,mv88e6190";
reg = <0x11>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(1)>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -511,34 +529,42 @@ mdio {
switch1phy1: switch1phy1@1 {
reg = <0x1>;
+ interrupts-extended = <&switch1_peridot 1 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy2: switch1phy2@2 {
reg = <0x2>;
+ interrupts-extended = <&switch1_peridot 2 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy3: switch1phy3@3 {
reg = <0x3>;
+ interrupts-extended = <&switch1_peridot 3 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy4: switch1phy4@4 {
reg = <0x4>;
+ interrupts-extended = <&switch1_peridot 4 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy5: switch1phy5@5 {
reg = <0x5>;
+ interrupts-extended = <&switch1_peridot 5 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy6: switch1phy6@6 {
reg = <0x6>;
+ interrupts-extended = <&switch1_peridot 6 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy7: switch1phy7@7 {
reg = <0x7>;
+ interrupts-extended = <&switch1_peridot 7 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy8: switch1phy8@8 {
reg = <0x8>;
+ interrupts-extended = <&switch1_peridot 8 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -622,12 +648,14 @@ port-sfp@a {
};
};
- switch1@2 {
+ switch1_topaz: switch1@2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
dsa,member = <0 1>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -636,18 +664,22 @@ mdio {
switch1phy1_topaz: switch1phy1@11 {
reg = <0x11>;
+ interrupts-extended = <&switch1_topaz 0x11 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy2_topaz: switch1phy2@12 {
reg = <0x12>;
+ interrupts-extended = <&switch1_topaz 0x12 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy3_topaz: switch1phy3@13 {
reg = <0x13>;
+ interrupts-extended = <&switch1_topaz 0x13 IRQ_TYPE_LEVEL_HIGH>;
};
switch1phy4_topaz: switch1phy4@14 {
reg = <0x14>;
+ interrupts-extended = <&switch1_topaz 0x14 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -689,12 +721,14 @@ port@5 {
};
};
- switch2@12 {
+ switch2_peridot: switch2@12 {
compatible = "marvell,mv88e6190";
reg = <0x12>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_PERIDOT(2)>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -703,34 +737,42 @@ mdio {
switch2phy1: switch2phy1@1 {
reg = <0x1>;
+ interrupts-extended = <&switch2_peridot 1 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy2: switch2phy2@2 {
reg = <0x2>;
+ interrupts-extended = <&switch2_peridot 2 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy3: switch2phy3@3 {
reg = <0x3>;
+ interrupts-extended = <&switch2_peridot 3 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy4: switch2phy4@4 {
reg = <0x4>;
+ interrupts-extended = <&switch2_peridot 4 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy5: switch2phy5@5 {
reg = <0x5>;
+ interrupts-extended = <&switch2_peridot 5 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy6: switch2phy6@6 {
reg = <0x6>;
+ interrupts-extended = <&switch2_peridot 6 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy7: switch2phy7@7 {
reg = <0x7>;
+ interrupts-extended = <&switch2_peridot 7 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy8: switch2phy8@8 {
reg = <0x8>;
+ interrupts-extended = <&switch2_peridot 8 IRQ_TYPE_LEVEL_HIGH>;
};
};
@@ -805,12 +847,14 @@ port-sfp@a {
};
};
- switch2@2 {
+ switch2_topaz: switch2@2 {
compatible = "marvell,mv88e6085";
reg = <0x2>;
dsa,member = <0 2>;
interrupt-parent = <&moxtet>;
interrupts = <MOXTET_IRQ_TOPAZ>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
status = "disabled";
mdio {
@@ -819,18 +863,22 @@ mdio {
switch2phy1_topaz: switch2phy1@11 {
reg = <0x11>;
+ interrupts-extended = <&switch2_topaz 0x11 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy2_topaz: switch2phy2@12 {
reg = <0x12>;
+ interrupts-extended = <&switch2_topaz 0x12 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy3_topaz: switch2phy3@13 {
reg = <0x13>;
+ interrupts-extended = <&switch2_topaz 0x13 IRQ_TYPE_LEVEL_HIGH>;
};
switch2phy4_topaz: switch2phy4@14 {
reg = <0x14>;
+ interrupts-extended = <&switch2_topaz 0x14 IRQ_TYPE_LEVEL_HIGH>;
};
};
However, as I had explained in one of the first discussions here:
https://lore.kernel.org/netdev/20210901012826.iuy2bhvkrgahhrl7@skbuf/
it was always hit-or-miss whether the above device tree had an issue
with fw_devlink or not: it depended on how the driver was written (and
the mv88e6xxx switch driver was tricking the fw_devlink logic from that
time to drop the device links because of an unrelated -EPROBE_DEFER).
What I had done to "untrick" fw_devlink so that I could see the issue
(which was originally reported by Alvin Šipraga) was to modify the
mv88e6xxx driver, and change the placement of mv88e6xxx_mdios_register()
to a point after which we will never hit -EPROBE_DEFER (from driver probe()
to the dsa_switch_ops :: setup() method):
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 0a5d6c7bb128..48650465660d 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3672,11 +3672,18 @@ static int mv88e6390_setup_errata(struct mv88e6xxx_chip *chip)
return mv88e6xxx_software_reset(chip);
}
+static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
+ struct device_node *np);
+static void mv88e6xxx_mdios_unregister(struct mv88e6xxx_chip *chip);
+
static void mv88e6xxx_teardown(struct dsa_switch *ds)
{
+ struct mv88e6xxx_chip *chip = ds->priv;
+
mv88e6xxx_teardown_devlink_params(ds);
dsa_devlink_resources_unregister(ds);
mv88e6xxx_teardown_devlink_regions_global(ds);
+ mv88e6xxx_mdios_unregister(chip);
}
static int mv88e6xxx_setup(struct dsa_switch *ds)
@@ -3686,6 +3693,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
int err;
int i;
+ err = mv88e6xxx_mdios_register(chip, chip->dev->of_node);
+ if (err)
+ return err;
+
chip->ds = ds;
ds->slave_mii_bus = mv88e6xxx_default_mdio_bus(chip);
@@ -3811,8 +3822,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
unlock:
mv88e6xxx_reg_unlock(chip);
- if (err)
+ if (err) {
+ mv88e6xxx_mdios_unregister(chip);
return err;
+ }
/* Have to be called without holding the register lock, since
* they take the devlink lock, and we later take the locks in
@@ -3837,6 +3850,7 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
mv88e6xxx_teardown_devlink_params(ds);
out_resources:
dsa_devlink_resources_unregister(ds);
+ mv88e6xxx_mdios_unregister(chip);
return err;
}
@@ -7220,18 +7234,12 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
if (err)
goto out_g1_atu_prob_irq;
- err = mv88e6xxx_mdios_register(chip, np);
- if (err)
- goto out_g1_vtu_prob_irq;
-
err = mv88e6xxx_register_switch(chip);
if (err)
- goto out_mdio;
+ goto out_g1_vtu_prob_irq;
return 0;
-out_mdio:
- mv88e6xxx_mdios_unregister(chip);
out_g1_vtu_prob_irq:
mv88e6xxx_g1_vtu_prob_irq_free(chip);
out_g1_atu_prob_irq:
@@ -7268,7 +7276,6 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
mv88e6xxx_phy_destroy(chip);
mv88e6xxx_unregister_switch(chip);
- mv88e6xxx_mdios_unregister(chip);
mv88e6xxx_g1_vtu_prob_irq_free(chip);
mv88e6xxx_g1_atu_prob_irq_free(chip);
After applying both of the above changes on top of yours, I confirm that
the PHYs on the mv88e6xxx on Turris MOX still probe with their specific
PHY driver rather than the generic one, and with interrupts (not poll mode):
[ 6.125894] mv88e6085 d0032004.mdio-mii:11 lan9 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:01] driver [Marvell 88E6390 Family] (irq=49)
[ 6.222024] mv88e6085 d0032004.mdio-mii:11 lan10 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:02] driver [Marvell 88E6390 Family] (irq=50)
[ 6.277554] mv88e6085 d0032004.mdio-mii:11 lan11 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:03] driver [Marvell 88E6390 Family] (irq=51)
[ 6.361556] mv88e6085 d0032004.mdio-mii:11 lan12 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:04] driver [Marvell 88E6390 Family] (irq=52)
[ 6.445574] mv88e6085 d0032004.mdio-mii:11 lan13 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:05] driver [Marvell 88E6390 Family] (irq=53)
[ 6.529560] mv88e6085 d0032004.mdio-mii:11 lan14 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:06] driver [Marvell 88E6390 Family] (irq=54)
[ 6.589555] mv88e6085 d0032004.mdio-mii:11 lan15 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:07] driver [Marvell 88E6390 Family] (irq=55)
[ 6.673559] mv88e6085 d0032004.mdio-mii:11 lan16 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:08] driver [Marvell 88E6390 Family] (irq=56)
[ 6.733558] mv88e6085 d0032004.mdio-mii:12 lan17 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:01] driver [Marvell 88E6390 Family] (irq=74)
[ 6.817557] mv88e6085 d0032004.mdio-mii:12 lan18 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:02] driver [Marvell 88E6390 Family] (irq=75)
[ 6.889628] mv88e6085 d0032004.mdio-mii:12 lan19 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:03] driver [Marvell 88E6390 Family] (irq=76)
[ 6.973593] mv88e6085 d0032004.mdio-mii:12 lan20 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:04] driver [Marvell 88E6390 Family] (irq=77)
[ 7.057572] mv88e6085 d0032004.mdio-mii:12 lan21 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:05] driver [Marvell 88E6390 Family] (irq=78)
[ 7.109547] mv88e6085 d0032004.mdio-mii:12 lan22 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:06] driver [Marvell 88E6390 Family] (irq=79)
[ 7.193553] mv88e6085 d0032004.mdio-mii:12 lan23 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:07] driver [Marvell 88E6390 Family] (irq=80)
[ 7.277550] mv88e6085 d0032004.mdio-mii:12 lan24 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:08] driver [Marvell 88E6390 Family] (irq=81)
[ 7.365556] mv88e6085 d0032004.mdio-mii:10 lan1 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:01] driver [Marvell 88E6390 Family] (irq=109)
[ 7.421549] mv88e6085 d0032004.mdio-mii:10 lan2 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:02] driver [Marvell 88E6390 Family] (irq=110)
[ 7.505554] mv88e6085 d0032004.mdio-mii:10 lan3 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:03] driver [Marvell 88E6390 Family] (irq=111)
[ 7.589571] mv88e6085 d0032004.mdio-mii:10 lan4 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:04] driver [Marvell 88E6390 Family] (irq=112)
[ 7.673560] mv88e6085 d0032004.mdio-mii:10 lan5 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:05] driver [Marvell 88E6390 Family] (irq=113)
[ 7.733547] mv88e6085 d0032004.mdio-mii:10 lan6 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:06] driver [Marvell 88E6390 Family] (irq=114)
[ 7.817555] mv88e6085 d0032004.mdio-mii:10 lan7 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:07] driver [Marvell 88E6390 Family] (irq=115)
[ 7.901572] mv88e6085 d0032004.mdio-mii:10 lan8 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:08] driver [Marvell 88E6390 Family] (irq=116)
even though I am seeing these error messages earlier in the boot process (maybe this is something to look into):
[ 0.910219] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910228] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910237] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910244] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910251] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910259] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910266] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910273] mdio_bus d0032004.mdio-mii:10: Failed to create device link with d0032004.mdio-mii:10
[ 0.910936] mv88e6085 d0032004.mdio-mii:10: switch 0x3900 detected: Marvell 88E6390, revision 1
[ 0.928360] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928380] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928388] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928396] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928403] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928410] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928418] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928425] mdio_bus d0032004.mdio-mii:11: Failed to create device link with d0032004.mdio-mii:11
[ 0.928993] mv88e6085 d0032004.mdio-mii:11: switch 0x1900 detected: Marvell 88E6190, revision 1
[ 0.943306] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943327] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943334] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943342] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943349] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943357] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943364] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943371] mdio_bus d0032004.mdio-mii:12: Failed to create device link with d0032004.mdio-mii:12
[ 0.943879] mv88e6085 d0032004.mdio-mii:12: switch 0x1900 detected: Marvell 88E6190, revision 1
If _on top_ of all the above, I also remove the logic that sets FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD:
drivers/net/phy/mdio_bus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 00d5bcdf0e6f..4d4c42771d37 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -665,9 +665,9 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
if (!bus->read && !bus->read_c45)
return -EINVAL;
- if (bus->parent && bus->parent->of_node)
- bus->parent->of_node->fwnode.flags |=
- FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD;
+// if (bus->parent && bus->parent->of_node)
+// bus->parent->of_node->fwnode.flags |=
+// FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD;
WARN(bus->state != MDIOBUS_ALLOCATED &&
bus->state != MDIOBUS_UNREGISTERED,
then *finally* I get something approximating Alvin's reported issue.
In my case, one switch out of 3 gets its PHYs bound to the Generic PHY
driver (why not all is a story for another time):
[ 6.106204] mv88e6085 d0032004.mdio-mii:11 lan9 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:01] driver [Marvell 88E6390 Family] (irq=49)
[ 6.193561] mv88e6085 d0032004.mdio-mii:11 lan10 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:02] driver [Marvell 88E6390 Family] (irq=50)
[ 6.249654] mv88e6085 d0032004.mdio-mii:11 lan11 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:03] driver [Marvell 88E6390 Family] (irq=51)
[ 6.333580] mv88e6085 d0032004.mdio-mii:11 lan12 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:04] driver [Marvell 88E6390 Family] (irq=52)
[ 6.417577] mv88e6085 d0032004.mdio-mii:11 lan13 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:05] driver [Marvell 88E6390 Family] (irq=53)
[ 6.501561] mv88e6085 d0032004.mdio-mii:11 lan14 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:06] driver [Marvell 88E6390 Family] (irq=54)
[ 6.561655] mv88e6085 d0032004.mdio-mii:11 lan15 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:07] driver [Marvell 88E6390 Family] (irq=55)
[ 6.645583] mv88e6085 d0032004.mdio-mii:11 lan16 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch1@...mdio:08] driver [Marvell 88E6390 Family] (irq=56)
[ 6.733557] mv88e6085 d0032004.mdio-mii:12 lan17 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:01] driver [Marvell 88E6390 Family] (irq=74)
[ 6.817563] mv88e6085 d0032004.mdio-mii:12 lan18 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:02] driver [Marvell 88E6390 Family] (irq=75)
[ 6.873653] mv88e6085 d0032004.mdio-mii:12 lan19 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:03] driver [Marvell 88E6390 Family] (irq=76)
[ 6.957582] mv88e6085 d0032004.mdio-mii:12 lan20 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:04] driver [Marvell 88E6390 Family] (irq=77)
[ 7.041567] mv88e6085 d0032004.mdio-mii:12 lan21 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:05] driver [Marvell 88E6390 Family] (irq=78)
[ 7.093561] mv88e6085 d0032004.mdio-mii:12 lan22 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:06] driver [Marvell 88E6390 Family] (irq=79)
[ 7.177476] mv88e6085 d0032004.mdio-mii:12 lan23 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:07] driver [Marvell 88E6390 Family] (irq=80)
[ 7.245560] mv88e6085 d0032004.mdio-mii:12 lan24 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch2@...mdio:08] driver [Marvell 88E6390 Family] (irq=81)
[ 7.269178] mv88e6085 d0032004.mdio-mii:10 lan1 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:01] driver [Generic PHY] (irq=POLL)
[ 7.288234] mv88e6085 d0032004.mdio-mii:10 lan2 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:02] driver [Generic PHY] (irq=POLL)
[ 7.307295] mv88e6085 d0032004.mdio-mii:10 lan3 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:03] driver [Generic PHY] (irq=POLL)
[ 7.326342] mv88e6085 d0032004.mdio-mii:10 lan4 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:04] driver [Generic PHY] (irq=POLL)
[ 7.345384] mv88e6085 d0032004.mdio-mii:10 lan5 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:05] driver [Generic PHY] (irq=POLL)
[ 7.364449] mv88e6085 d0032004.mdio-mii:10 lan6 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:06] driver [Generic PHY] (irq=POLL)
[ 7.383496] mv88e6085 d0032004.mdio-mii:10 lan7 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:07] driver [Generic PHY] (irq=POLL)
[ 7.402563] mv88e6085 d0032004.mdio-mii:10 lan8 (uninitialized): PHY [!soc!internal-regs@...00000!mdio@...04!switch0@...mdio:08] driver [Generic PHY] (irq=POLL)
So I guess that FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD does something.
OTOH, if I apply just my patch to remove the FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD,
but without making the device tree change or the mv88e6xxx driver change, the PHYs
still probe with the correct driver and with interrupts (i.e. they don't get their
probing deferred). This also seems to prove my point that my patches to bring the
Turris MOX to a testable state for this fwnode flag are indeed required.
HTH.
Powered by blists - more mailing lists