linux-kernel - Re: [PATCH v5 5/5] Driver: VMBus: Add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2023 16:37:28 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Saurabh Singh Sengar <ssengar@...ux.microsoft.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, kys@...rosoft.com,
        haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
        daniel.lezcano@...aro.org, tglx@...utronix.de,
        virtualization@...ts.linux-foundation.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-hyperv@...r.kernel.org, mikelley@...rosoft.com,
        dphadke@...ux.microsoft.com
Subject: Re: [PATCH v5 5/5] Driver: VMBus: Add device tree support

On Thu, Feb 9, 2023 at 11:46 AM Saurabh Singh Sengar
<ssengar@...ux.microsoft.com> wrote:
>
> On Thu, Feb 09, 2023 at 09:50:31AM -0600, Rob Herring wrote:
> > On Thu, Feb 9, 2023 at 6:15 AM Saurabh Sengar
> > <ssengar@...ux.microsoft.com> wrote:
> > >
> > > Update the driver to support device tree boot as well along with ACPI.
> >
> > Devicetree

[...]

> > > +       for_each_of_range(&parser, &range) {
> > > +               struct resource *res;
> > > +
> > > +               res = kzalloc(sizeof(*res), GFP_ATOMIC);
> > > +               if (!res)
> > > +                       return -ENOMEM;
> > > +
> > > +               res->name = "hyperv mmio";
> > > +               res->flags = IORESOURCE_MEM | IORESOURCE_MEM_64;
> > > +               res->start = range.pci_addr;
> >
> > This is not PCI. It's a union, so use 'bus_addr' instead.
> >
> > But wait, resources and IORESOURCE_MEM are *CPU* addresses. You need
> > cpu_addr here. Your DT happens to do 1:1 addresses so it happens to
> > work either way.
>
> bus_addr works for us, will send V6

Sigh. bus_addr may work, but is wrong as I explained.

And you've already sent v6... Please slow down your pace with sending
new versions. 4 versions in a week is too much. Give others time to
comment and me to respond to discussions. Like a week...

Rob