linux-kernel - Re: [PATCH] media: mediatek: vcodec: Force capture queue format to MM21

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3754485de6cc5a4b4b1246fb0bf86f13711cf4f.camel@mediatek.com>
Date:   Fri, 10 Feb 2023 05:56:37 +0000
From:   Yunfei Dong (董云飞) 
        <Yunfei.Dong@...iatek.com>
To:     "tomm.merciai@...il.com" <tomm.merciai@...il.com>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "nicolas@...fresne.ca" <nicolas@...fresne.ca>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "frkoenig@...omium.org" <frkoenig@...omium.org>,
        Tiffany Lin (林慧珊) 
        <tiffany.lin@...iatek.com>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "stevecho@...omium.org" <stevecho@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "hsinyi@...omium.org" <hsinyi@...omium.org>,
        "benjamin.gaignard@...labora.com" <benjamin.gaignard@...labora.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH] media: mediatek: vcodec: Force capture queue format to
 MM21

Hi AngeloGioacchino,

Thanks for your suggestion.
Add Fixes tag in patch v2.

Best Regards,
Yunfei Dong

On Thu, 2023-02-09 at 13:56 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 09:57, Tommaso Merciai ha scritto:
> > Hi Yunfei Dong,
> > 
> > On Thu, Feb 09, 2023 at 03:40:25PM +0800, Yunfei Dong wrote:
> > > In order to conver the format of capture queue from mediatek MM21
> > > to
> > > standard yuv420 with Libyuv, need to force capture queue format
> > > to
> > > MM21 for Libyuv can't covert mediatek MT21 format.
> > 
> > Sorry, just some clarifications on my side, just to understand :)
> > The problem is that libyuv can't convert mm21 format into yuv420
> > than you need to use mm21 (forcing this).
> > Did I understand correctly?
> > 
> 
> vcodec can output either MM21 or MT21C; libyuv can't handle the MT21C
> format,
> at least for now, hence he is forcing vcodec to always give MM21 for
> things
> to actually work... at a later time, I hope and suppose that this
> driver will
> change to not force anything anymore.
> 
> > Thanks in advance,
> > Tommaso
> > 
> 
> Yunfei, since this is required to get "basic" functionality, this
> commit needs
> a Fixes tag: can you please add the right one?
> 
> Thanks!
> Angelo
> 
>