lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 10 Feb 2023 11:38:37 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/7] usb: typec: ucsi: add PMIC Glink UCSI driver

On Fri, Feb 10, 2023 at 11:31:08AM +0100, Neil Armstrong wrote:
> On 31/01/2023 10:16, Greg Kroah-Hartman wrote:
> > On Mon, Jan 30, 2023 at 10:54:32AM +0100, Neil Armstrong wrote:
> > > Introduce the UCSI PMIC Glink aux driver that communicates
> > > with the aDSP firmware with the UCSI protocol which handles
> > > the USB-C Port(s) Power Delivery.
> > > 
> > > The UCSI messaging is necessary on newer Qualcomm SoCs to
> > > provide USB role switch and altmode notifications.
> > > 
> > > Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> > > ---
> > >   drivers/usb/typec/ucsi/Kconfig      |   7 +
> > >   drivers/usb/typec/ucsi/Makefile     |   1 +
> > >   drivers/usb/typec/ucsi/ucsi_glink.c | 321 ++++++++++++++++++++++++++++++++++++
> > >   3 files changed, 329 insertions(+)
> > > 
> > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/Kconfig
> > > index 8f9c4b9f31f7..dee6069e46a2 100644
> > > --- a/drivers/usb/typec/ucsi/Kconfig
> > > +++ b/drivers/usb/typec/ucsi/Kconfig
> > > @@ -58,4 +58,11 @@ config UCSI_STM32G0
> > >   	  To compile the driver as a module, choose M here: the module will be
> > >   	  called ucsi_stm32g0.
> > > +config UCSI_PMIC_GLINK
> > > +	tristate "UCSI Qualcomm PMIC GLINK Interface Driver"
> > > +	depends on QCOM_PMIC_GLINK
> > 
> > No way to test build this code without this option?
> 
> Nop, the QCOM_PMIC_GLINK is a build dependency, this can't be removed

Then perhaps the QCOM_PMIC_GLINK code needs to be fixed up to allow for
it to be built on all platforms properly?  Otherwise you are
guaranteeing you will not get much, if any, build coverage and api
changes will cause this code to stagnate over time :(

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ