linux-kernel - Re: [PATCH 0/3] Touch Bar and Keyboard backlight driver for Intel Macs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230210214737.2ef942c6@redecorated-mbp>
Date:   Fri, 10 Feb 2023 21:47:37 +1100
From:   Orlando Chamberlain <orlandoch.dev@...il.com>
To:     Aditya Garg <gargaditya08@...e.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        "jkosina@...e.cz" <jkosina@...e.cz>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        Andy Shevchenko <andy@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "ronald@...ovation.ch" <ronald@...ovation.ch>,
        "kekrby@...il.com" <kekrby@...il.com>,
        Thomas Weißschuh <thomas@...ch.de>
Subject: Re: [PATCH 0/3] Touch Bar and Keyboard backlight driver for Intel
 Macs

On Fri, 10 Feb 2023 10:41:07 +0000
Aditya Garg <gargaditya08@...e.com> wrote:

> > 
> > Quick observation. Do you miss the Co-developed-by: tags in the
> > patches?  
> 
> Most of the changes are minor in the 1st and 2nd patch, we haven't
> changed most of the code. The changes were written as per the
> documentation given in
> https://www.kernel.org/doc/html/latest/maintainer/modifying-patches.html
> 
> Do you think a Co-developed-by is still required?
> 
> The third patch was actually written by 2 people, so there is a
> Co-developed-by there.
> 

To add onto this, for patches 1 and 2, as we haven't been able to
contact the original author (Ronald), I think the only ways we are
allowed to make changes are either doing them in separate patches, or
with the [name <email>: changes] tags. For the latter I thought you had
to do a Signed-off-by after it, but given the changes aren't just to
make the patch apply on a newer version, do you think the
Co-developed-by tag is also needed?

> > 
> > -- 
> > With Best Regards,
> > Andy Shevchenko  
>