[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a0a141ef-b5ab-f84a-9a77-7b6d1f54ccc9@linaro.org>
Date: Fri, 10 Feb 2023 11:59:54 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sergio Paracuellos <sergio.paracuellos@...il.com>,
linux-watchdog@...r.kernel.org
Cc: wim@...ux-watchdog.org, linux@...ck-us.net, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
arinc.unal@...nc9.com, tsbogend@...ha.franken.de,
p.zabel@...gutronix.de, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, linux-mips@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: watchdog: mt7621-wdt: add phandle to
access system controller registers
On 10/02/2023 07:56, Sergio Paracuellos wrote:
> MT7621 SoC provides a system controller node for accessing to some registers.
> Add a phandle to this node to avoid using MIPS related arch operations and
I don't understand this part. You claim you add a phandle to this node,
but your binding suggest you add here a phandle to other node.
> includes in watchdog driver code.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
> ---
> .../bindings/watchdog/mediatek,mt7621-wdt.yaml | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> index b2b17fdf4..3c545065f 100644
> --- a/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mt7621-wdt.yaml
> @@ -14,11 +14,18 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt7621-wdt
> + items:
> + - const: mediatek,mt7621-wdt
> + - const: syscon
>
> reg:
> maxItems: 1
>
> + ralink,sysctl:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + phandle of syscon used to control system registers
This needs to be more specific - which syscon? It also does not fit your
commit msg.
Best regards,
Krzysztof
Powered by blists - more mailing lists