linux-kernel - Re: [PATCH V2 1/3] dt-bindings: clock: Add Loongson-1 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c06f5b63-2667-2a01-fa1f-7efe4c6f3867@linaro.org>
Date:   Fri, 10 Feb 2023 12:38:09 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Keguang Zhang <keguang.zhang@...il.com>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH V2 1/3] dt-bindings: clock: Add Loongson-1 clock

On 09/02/2023 14:26, Keguang Zhang wrote:
> Add devicetree binding document and related header file
> for the Loongson-1 clock.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@...il.com>
> ---
> V1 -> V2: Change to one clock controller
>           Add clock-related dt-binding header file
>           Fix the warning of dt_binding_check
> ---

Thank you for your patch. There is something to discuss/improve.

> diff --git a/include/dt-bindings/clock/loongson,ls1x-clk.h b/include/dt-bindings/clock/loongson,ls1x-clk.h
> new file mode 100644
> index 000000000000..579552c5f14b
> --- /dev/null
> +++ b/include/dt-bindings/clock/loongson,ls1x-clk.h
> @@ -0,0 +1,19 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */

Same license as binding please.

> +/*
> + * Loongson-1 clock tree IDs
> + *
> + * Copyright (C) 2023 Keguang Zhang <keguang.zhang@...il.com>
> + */

Best regards,
Krzysztof