linux-kernel - Re: [PATCH v2] media: venus: dec: Fix handling of the start cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJMMOfM41dfqx0NoiHGE=8X5hoRHo1=qPEp4KXLP1kygestEJQ@mail.gmail.com>
Date:   Fri, 10 Feb 2023 16:18:47 +0100
From:   Michał Krawczyk <mk@...ihalf.com>
To:     Vikash Garodia <vgarodia@....qualcomm.com>
Cc:     Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
        "Vikash Garodia (QUIC)" <quic_vgarodia@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mw@...ihalf.com" <mw@...ihalf.com>
Subject: Re: [PATCH v2] media: venus: dec: Fix handling of the start cmd

Hi,

I'm wondering if there are any more comments for this patch? I would
be happy to clarify anything that's unclear or improve the code if
needed.

I know it's pretty late, but it would be really great if this fix
could land before v6.2 is released, so I'd appreciate your help and
review.

Thank you,
Michał

wt., 7 lut 2023 o 12:15 Michał Krawczyk <mk@...ihalf.com> napisał(a):
>
> wt., 7 lut 2023 o 10:54 Vikash Garodia <vgarodia@....qualcomm.com> napisał(a):
> > I have reviewed the patch, and the drain sequence handling looks good to me.
> > Could you share some details on the test client which you are using to catch this issue ?
>
> Hi Vikash,
>
> Thank you for looking at the code!
>
> I've been testing it using the Chromium implementation of the V4L2
> codec [1]. Meanwhile, we were running a test suite which changes the
> encryption method in the middle of the video decoding. This triggers
> the flush behavior and the Chromium sends the stop/start cmd to the
> V4L2 kernel component, and the test expects the video to continue the
> playback normally. Unfortunately, it was causing a stall of the video
> at the same time.
>
> [1] https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/v4l2/
>
> >
> > > Thank you,
> > > Michał
> >
> > Thanks,
> > Vikash