linux-kernel - Re: [PATCH 03/14] Move COMPAT_ATM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <7493f543-bf02-4bfe-90bd-a01d3c52cb52@app.fastmail.com>
Date:   Fri, 10 Feb 2023 16:10:16 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Thomas Huth" <thuth@...hat.com>,
        "Palmer Dabbelt" <palmer@...belt.com>, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Jakub Kicinski" <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>
Cc:     "Alexander Viro" <viro@...iv.linux.org.uk>,
        aishchuk@...ux.vnet.ibm.com, aarcange@...hat.com,
        "Andrew Morton" <akpm@...ux-foundation.org>,
        "Andy Lutomirski" <luto@...nel.org>,
        "Arnaldo Carvalho de Melo" <acme@...nel.org>,
        "Baoquan He" <bhe@...hat.com>, 3chas3@...il.com, chris@...kel.net,
        dave@...1.net, dyoung@...hat.com, drysdale@...gle.com,
        "Eric W. Biederman" <ebiederm@...ssion.com>, geoff@...radead.org,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "H. Peter Anvin" <hpa@...or.com>, "Ingo Molnar" <mingo@...nel.org>,
        iulia.manda21@...il.com, plagnioj@...osoft.com, jikos@...nel.org,
        "Josh Triplett" <josh@...htriplett.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        linux-fsdevel@...r.kernel.org, mathieu.desnoyers@...icios.com,
        "Max Filippov" <jcmvbkbc@...il.com>, paulmck@...ux.vnet.ibm.com,
        a.p.zijlstra@...llo.nl, "Thomas Gleixner" <tglx@...utronix.de>,
        vgoyal@...hat.com, x86@...nel.org,
        "David Howells" <dhowells@...hat.com>,
        "Peter Zijlstra" <peterz@...radead.org>,
        Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 03/14] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c

On Fri, Feb 10, 2023, at 15:55, Thomas Huth wrote:
> On 10/11/2015 02.31, Palmer Dabbelt wrote:
>> This used to be behind an #ifdef COMPAT_COMPAT, so most of userspace
>> wouldn't have seen the definition before.  Unfortunately this header
>> file became visible to userspace, so the definition has instead been
>> moved to net/atm/svc.c (the only user).
>> 
>> Signed-off-by: Palmer Dabbelt <palmer@...belt.com>
>> Reviewed-by: Andrew Waterman <waterman@...s.berkeley.edu>
>> Reviewed-by: Albert Ou <aou@...s.berkeley.edu>

Reviewed-by: Arnd Bergmann <arnd@...db.de>

It took me a bit to figure out why there is a separate command
code but no special handler for the compat structure, aside from
being in the wrong file it does look correct.

>> +#ifdef CONFIG_COMPAT
>> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */
>> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf)
>> +#endif

We could actually drop the #ifdef here as well, or moving into
the existing #ifdef.

>> +
>>   static int svc_create(struct net *net, struct socket *sock, int protocol,
>>   		      int kern);
>
> The CONFIG_* switch is still there in the atmdev.h uapi header ... could 
> somebody please pick this patch up to fix it?

It should get merged through the netdev tree, as Chas does not have
a separate git tree for drivers/atm.

I don't know what happened to the rest of the series, but if there are
additional patches that got lost, merging them all through either the
asm-generic or the mm tree would work as well.

Any chance you or Palmer could rebase the series to 6.2-rc and
see what remains?

    Arnd