linux-kernel - [PATCH] PCI: Honor firmware's device disabled status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230210164351.2687475-1-robh@kernel.org>
Date:   Fri, 10 Feb 2023 10:43:51 -0600
From:   Rob Herring <robh@...nel.org>
To:     Bjorn Helgaas <bhelgaas@...gle.com>
Cc:     Liu Peibao <liupeibao@...ngson.cn>,
        Binbin Zhou <zhoubinbin@...ngson.cn>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] PCI: Honor firmware's device disabled status

If a device has a firmware node (DT/ACPI), and the device is marked
disabled, that is currently ignored. Add a check for this condition
and bail out creating the pci_dev.

This assumes the config space for the device can still be accessed
because they already have by this point in order to identify the device.

Cc: Liu Peibao <liupeibao@...ngson.cn>
Cc: Binbin Zhou <zhoubinbin@...ngson.cn>
Cc: Huacai Chen <chenhuacai@...ngson.cn>
Signed-off-by: Rob Herring <robh@...nel.org>
---
Please test if this works for Loongson.
---
 drivers/pci/probe.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 1779582fb500..b1d80c1d7a69 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1841,6 +1841,8 @@ int pci_setup_device(struct pci_dev *dev)
 
 	pci_set_of_node(dev);
 	pci_set_acpi_fwnode(dev);
+	if (dev->dev.fwnode && !fwnode_device_is_available(dev->dev.fwnode))
+		return -ENODEV;
 
 	pci_dev_assign_slot(dev);
 
-- 
2.39.1