linux-kernel - Re: [PATCH v2 0/3] mm/damon: deprecate DAMON debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20230210182843.83527-1-sj@kernel.org>
Date:   Fri, 10 Feb 2023 18:28:43 +0000
From:   SeongJae Park <sj@...nel.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     SeongJae Park <sj@...nel.org>, Jonathan Corbet <corbet@....net>,
        damon@...ts.linux.dev, linux-mm@...ck.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v2 0/3] mm/damon: deprecate DAMON debugfs interface

On Fri, 10 Feb 2023 04:48:35 +0000 SeongJae Park <sj@...nel.org> wrote:

> Changes from v1
> (https://lore.kernel.org/damon/20230209192009.7885-1-sj@kernel.org/)
> - Split DAMON debugfs file open warning message (Randy Dunlap)

I usually sent this kind of update for after-merged-into-mm-unstable tree
patches individusally as fixup, but this time I sent whole patchset as a new
version, because I was out of my mind.

For someone who may prefer the usual for-fixup individual patch, attaching the
version below.


Thanks,
SJ

================================= 8< ==========================================
From: SeongJae Park <sj@...nel.org>
Date: Fri, 10 Feb 2023 04:37:19 +0000
Subject: [PATCH mm-unstable] mm/damon/dbgfs: break too long deprecation
 warning message

DAMON debugfs interface deprecation message, which is introduced by
commit 234a68e24b12 ("mm/damon/dbgfs: print DAMON debugfs interface
deprecation message") of mm-unstable, is too long.  Break down into
multiple strings for better code readability.

Fixes: 234a68e24b12 ("mm/damon/dbgfs: print DAMON debugfs interface deprecation message") # mm-unstable
Suggested-by: Randy Dunlap <rdunlap@...radead.org>
Signed-off-by: SeongJae Park <sj@...nel.org>
---
 mm/damon/dbgfs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index e551a20b35e3..124f0f8c97b7 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -22,7 +22,10 @@ static DEFINE_MUTEX(damon_dbgfs_lock);

 static void damon_dbgfs_warn_deprecation(void)
 {
-       pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS).  If you depend on this and cannot move, please report your usecase to damon@...ts.linux.dev and linux-mm@...ck.org.\n");
+       pr_warn_once("DAMON debugfs interface is deprecated, "
+                    "so users should move to DAMON_SYSFS. If you cannot, "
+                    "please report your usecase to damon@...ts.linux.dev and "
+                    "linux-mm@...ck.org.\n");
 }

 /*
--
2.25.1