linux-kernel - Re: [PATCH] scsi: target: core: Added a blank line after target_remove_from_tmr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19b4a1e2-c8f8-dad1-51eb-c565fee405ee@oracle.com>
Date:   Sat, 11 Feb 2023 13:50:50 +0530
From:   ALOK TIWARI <alok.a.tiwari@...cle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-scsi@...r.kernel.org, darren.kenny@...cle.com,
        michael.christie@...cle.com, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, martin.petersen@...cle.com,
        d.bogdanov@...ro.com, r.bolshakov@...ro.com,
        target-devel@...r.kernel.org
Subject: Re: [PATCH] scsi: target: core: Added a blank line after
 target_remove_from_tmr_list()

commit "Fixes: 12b6fcd0ea7f" introduce that change in source code.
that's reason we are using "fixes:". back-porting that change is creating awkward manual conflict resolution.

Thanks,
Alok

On 2/11/2023 1:18 PM, Greg KH wrote:
> On Fri, Feb 10, 2023 at 09:55:22AM -0800, Alok Tiwari wrote:
>> There is no separate blank line between target_remove_from_tmr_list() and
>> transport_cmd_check_stop_to_fabric
>> As per coding-style, it is require to separate functions with one blank line.
>>
>> Fixes: 12b6fcd0ea7f ("scsi: target: core: Remove from tmr_list during LUN unlink")
>> Signed-off-by: Alok Tiwari <alok.a.tiwari@...cle.com>
>> ---
>>   drivers/target/target_core_transport.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
>> index 5926316252eb..f1cdf78fc5ef 100644
>> --- a/drivers/target/target_core_transport.c
>> +++ b/drivers/target/target_core_transport.c
>> @@ -691,6 +691,7 @@ static void target_remove_from_tmr_list(struct se_cmd *cmd)
>>   		spin_unlock_irqrestore(&dev->se_tmr_lock, flags);
>>   	}
>>   }
>> +
>>   /*
>>    * This function is called by the target core after the target core has
>>    * finished processing a SCSI command or SCSI TMF. Both the regular command
>> -- 
>> 2.39.1
>>
> Why is a coding style change tagged with a "fixes:" line and cc: stable?
>
> thanks,
>
> greg k-h