linux-kernel - Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane transaction layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4e7b6cc0c5623f8ed26a913ad16ee0b49a07c825.camel@mediatek.com>
Date:   Sat, 11 Feb 2023 08:49:40 +0000
From:   Yanchao Yang (杨彦超) 
        <Yanchao.Yang@...iatek.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     Chris Feng (冯保林) 
        <Chris.Feng@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mingliang Xu (徐明亮) 
        <mingliang.xu@...iatek.com>,
        Min Dong (董敏) <min.dong@...iatek.com>,
        "linuxwwan@...el.com" <linuxwwan@...el.com>,
        "m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
        Liang Lu (吕亮) <liang.lu@...iatek.com>,
        Haijun Liu (刘海军) 
        <haijun.liu@...iatek.com>,
        Haozhe Chang (常浩哲) 
        <Haozhe.Chang@...iatek.com>,
        Hua Yang (杨华) <Hua.Yang@...iatek.com>,
        "Xiayu.Zhang@...i" <Xiayu.Zhang@...i>,
        "ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>
Subject: Re: [PATCH net-next v2 08/12] net: wwan: tmi: Add data plane
 transaction layer

On Mon, 2023-01-30 at 12:05 -0800, Jakub Kicinski wrote:
> On Sun, 29 Jan 2023 08:51:00 +0000 Yanchao Yang (杨彦超) wrote:
> > > Please try to make the series smaller than 17,770 :/
> > > Strip stuff down to minimal working version.
> > > I don't think anyone can review 17kLoC in one sitting :/  
> > 
> > Thank your suggestion. I agree with you. Considering both the
> > control
> > plane and data plane are the minimal function for TMI driver, other
> > functions can be removed and submitted after the initial version is
> > approved. The whole patch can be reduced about 2k lines. Is it ok?
> > Or
> > do you have any more suggestions? Please help share it.
> 
> SGTM, thanks!

Hi Jakub,

Thank you for your suggestion. V3 is submitted, which has 13k lines.
It's reduced 4k+ lines compared with V2. Please help review it and
share your advice at your convenience.

Many thanks.
Yanchao.yang