linux-kernel - Re: [PATCH v4 1/5] dt-bindings: watchdog: mt7621-wdt: add phandle to access system controller registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMhs-H_1dtdAmeNW9arK9JxhdWaQJwcMU1Pk7TOW1f5MREzzug@mail.gmail.com>
Date:   Sat, 11 Feb 2023 12:01:15 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     linux-watchdog@...r.kernel.org, wim@...ux-watchdog.org,
        linux@...ck-us.net, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        tsbogend@...ha.franken.de, p.zabel@...gutronix.de,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: watchdog: mt7621-wdt: add phandle to
 access system controller registers

On Sat, Feb 11, 2023 at 11:47 AM Arınç ÜNAL <arinc.unal@...nc9.com> wrote:
>
> On 11.02.2023 13:41, Sergio Paracuellos wrote:
> > On Sat, Feb 11, 2023 at 10:10 AM Arınç ÜNAL <arinc.unal@...nc9.com> wrote:
> >>
> >> Is this mediatek,sysctl property required after your changes on the
> >> watchdog code?
> >
> > I don't really understand the question :-) Yes, it is. Since we have
> > introduced a new phandle in the watchdog node to be able to access the
> > reset status register through the 'sysc' syscon node.
> > We need the bindings to be aligned with the mt7621.dtsi file and we
> > are getting the syscon regmap handler via
> > 'syscon_regmap_lookup_by_phandle()'. See PATCH 5 of the series, Arınç.
>
> I believe you need to put mediatek,sysctl under "required:".

Ah, I understood your question now :-). You meant 'required' property.
I need more coffee, I guess :-). I am not sure if you can add
properties as required after bindings are already mainlined for
compatibility issues. The problem with this SoC is that drivers become
mainlined before the device tree was so if things are properly fixed
now this kind of issues appear.  Let's see Krzysztof and Rob comments
for this.

Thanks,
    Sergio Paracuellos
>
> Arınç