linux-kernel - Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2746d301-3f8b-e61c-b2c8-088d25f94d47@linaro.org>
Date:   Sat, 11 Feb 2023 12:39:09 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Eric Chanudet <echanude@...hat.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P

On 10/02/2023 15:52, Eric Chanudet wrote:
> On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote:
>> On 09/02/2023 18:55, Eric Chanudet wrote:
>>> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>>>
>>>> Add the SoC ID entry for SA8775P.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> ---
>>>>  include/dt-bindings/arm/qcom,ids.h | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>
>>> Reviewed-by: Eric Chanudet <echanude@...hat.com>
>>> Tested-by: Eric Chanudet <echanude@...hat.com>
>>
>> How can you test a header? What type of testing Redhat does on the headers?
> 
> IIUC that ID is compared against the one read from SMEM by the socinfo
> driver. I meant to confirm it matched the number the board I have
> returned. My apologies in advance if that was inappropriate.

OK... I would say it is a review then, but can be also this way.

Best regards,
Krzysztof