linux-kernel - Heads-up: one change merged for -rc8 that might be good to have in the next 6.1.y release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <b74b2c93-bd0b-84c2-868b-d5376a16b020@leemhuis.info>
Date:   Sat, 11 Feb 2023 13:42:25 +0100
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>
Cc:     Bastien Nocera <hadess@...ess.net>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Linux kernel regressions list <regressions@...ts.linux.dev>,
        LKML <linux-kernel@...r.kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Heads-up: one change merged for -rc8 that might be good to have in
 the next 6.1.y release

Hi Greg. Would be great if you could pick up 690eb7dec72a ("HID:
logitech: Disable hi-res scrolling on USB") for the next 6.1.y release,
as it's fixing a regression I saw multiple people report.

The commit (see below) that was recently merged to mainline and has a
proper stable "Cc: <stable@...>" tag, so I guess you scripts will at
some point pick it up automatically. But I noticed you updated the
stable queue and hour ago and this patch afaics is not in it yet
(despite some other patches being in it that were merged later), so I
thought: just to be sure send a quick heads up.

Ciao, Thorsten

On 09.02.23 19:10, Linux Kernel Mailing List wrote:
> Commit:     690eb7dec72ae52d1d710d14a451844b4d0f4f19
> Parent:     ea427a222d8bdf2bc1a8a6da3ebe247f7dced70c
> Refname:    refs/heads/master
> Web:        https://git.kernel.org/torvalds/c/690eb7dec72ae52d1d710d14a451844b4d0f4f19
> Author:     Bastien Nocera <hadess@...ess.net>
> AuthorDate: Fri Feb 3 11:18:00 2023 +0100
> Committer:  Benjamin Tissoires <benjamin.tissoires@...hat.com>
> CommitDate: Mon Feb 6 10:58:15 2023 +0100
> 
>     HID: logitech: Disable hi-res scrolling on USB
>     
>     On some Logitech mice, such as the G903, and possibly the G403, the HID
>     events are generated on a different interface to the HID++ one.
>     
>     If we enable hi-res through the HID++ interface, the HID interface
>     wouldn't know anything about it, and handle the events as if they were
>     regular scroll events, making the mouse unusable.
>     
>     Disable hi-res scrolling on those devices until we implement scroll
>     events through HID++.
>     
>     Signed-off-by: Bastien Nocera <hadess@...ess.net>
>     Tested-by: Tobias Klausmann <klausman@...warzvogel.de>
>     Link: https://bugzilla.kernel.org/show_bug.cgi?id=216885
>     Fixes: 908d325e1665 ("HID: logitech-hidpp: Detect hi-res scrolling support")
>     Cc: stable@...r.kernel.org
>     Link: https://lore.kernel.org/r/20230203101800.139380-1-hadess@hadess.net
>     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> index abf2c95e4d0b0..9c1ee8e91e0ca 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -3978,7 +3978,8 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
>  	}
>  
>  	hidpp_initialize_battery(hidpp);
> -	hidpp_initialize_hires_scroll(hidpp);
> +	if (!hid_is_usb(hidpp->hid_dev))
> +		hidpp_initialize_hires_scroll(hidpp);
>  
>  	/* forward current battery state */
>  	if (hidpp->capabilities & HIDPP_CAPABILITY_HIDPP10_BATTERY) {
>