linux-kernel - Re: [PATCH RFT 0/3] drivers/thermal/rcar_gen3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y+eYjJIITr2rgz7e@sleipner.dyn.berto.se>
Date:   Sat, 11 Feb 2023 14:30:52 +0100
From:   Niklas Söderlund 
        <niklas.soderlund@...natech.se>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-renesas-soc@...r.kernel.org,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH RFT 0/3] drivers/thermal/rcar_gen3_thermal: add Gen4 fuse
 support

Hi Wolfram,

Thanks for your work.

On 2023-02-11 09:47:24 +0100, Wolfram Sang wrote:
> R-Car Gen4 has the fuse registers at different locations and with
> different names, but with the same purpose. So, first refactor IP core
> differences into a 'info' struct, then add the fuse_read callback to it.
> 
> Patches are based on top of:
> 
> [PATCH v2 0/3] drivers/thermal/rcar_gen3_thermal: Fix device initialization
> [PATCH 0/2] thermal: Add support for R-Car V4H
> 
> They have been tested on R-Car H3 ES2.0 and M3-N against regressions.
> Actual testing of the new fuses on S4-8 still needs to be done because I
> don't have access to such HW.
> 
> @Shimoda-san: maybe the BSP team or Test team can test these patches?
> 
> Looking forward to other review comments, too, of course.

For the whole series,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>

I boot tested this on V4H, but on that board the fuses where not set so 
the driver fall-back to the default values. We had a similar situation 
when we enabled fuses for Gen3. IIRC the BSP team helped out testing 
that on a board that had the fuses set.

> 
> Happy hacking,
> 
>    Wolfram
> 
> 
> Wolfram Sang (3):
>   drivers/thermal/rcar_gen3_thermal: introduce 'info' structure
>   drivers/thermal/rcar_gen3_thermal: refactor reading fuses into
>     seprarate function
>   drivers/thermal/rcar_gen3_thermal: add reading fuses for Gen4
> 
>  drivers/thermal/rcar_gen3_thermal.c | 141 ++++++++++++++++++++--------
>  1 file changed, 102 insertions(+), 39 deletions(-)
> 
> -- 
> 2.30.2
> 

-- 
Kind Regards,
Niklas Söderlund