[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e8ce6ab5-5db0-305b-f025-a4cef95fde58@wanadoo.fr>
Date: Sat, 11 Feb 2023 15:46:25 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: drv@...lo.com
Cc: broonie@...nel.org, kumarpraveen@...ux.microsoft.com,
linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org,
ssengar@...rosoft.com
Subject: Re: [PATCH] spi: Remove extra/duplicate constant from expression
Le 11/02/2023 à 10:59, Deepak R Varma a écrit :
> Constant SPI_TX_OCTAL is included twice while building the controller
> mode bits. Remove the extra constant.
> Issue identified using doublebitand.cocci Coccinelle semantic patch.
>
> Signed-off-by: Deepak R Varma <drv-asAA5fHt7EIAvxtiuMwx3w@...lic.gmane.org>
> ---
> drivers/spi/spi-sn-f-ospi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c
> index 348c6e1edd38..19284d6914fc 100644
> --- a/drivers/spi/spi-sn-f-ospi.c
> +++ b/drivers/spi/spi-sn-f-ospi.c
> @@ -611,7 +611,7 @@ static int f_ospi_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> ctlr->mode_bits = SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTAL
> - | SPI_RX_DUAL | SPI_RX_QUAD | SPI_TX_OCTAL
> + | SPI_RX_DUAL | SPI_RX_QUAD
Or maybe s/SPI_TX_OCTAL/SPI_RX_OCTAL/ ?
CJ
> | SPI_MODE_0 | SPI_MODE_1 | SPI_LSB_FIRST;
> ctlr->mem_ops = &f_ospi_mem_ops;
> ctlr->bus_num = -1;
Powered by blists - more mailing lists