[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y+fE7gIMD4BDCffy@duo.ucw.cz>
Date: Sat, 11 Feb 2023 17:40:14 +0100
From: Pavel Machek <pavel@....cz>
To: Gergo Koteles <soyer@....hu>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Jiri Kosina <jikos@...nel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
Caleb Connolly <caleb@...nolly.tech>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add
tri-state-key
Hi!
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -52,6 +52,43 @@ key-vol-up {
> };
> };
>
> + tri-state-key {
> + compatible = "gpio-keys";
> + label = "Tri-state key";
> + pinctrl-names = "default";
> + pinctrl-0 = <&tri_state_key_default>;
> + state-top {
> + label = "Tri-state key top";
"top/middle" is not too useful. Do we need the label at all? If so,
should it say "loud/vibrations only/mute"?
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists