linux-kernel - Re: [PATCH 03/12] pata_parport: remove devtype from struct pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <909afe94-d786-a94c-5142-818e540705cc@omp.ru>
Date:   Sat, 11 Feb 2023 22:11:06 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Ondrej Zary <linux@...y.sk>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>
CC:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Tim Waugh <tim@...erelk.net>, <linux-block@...r.kernel.org>,
        <linux-parport@...ts.infradead.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/12] pata_parport: remove devtype from struct pi_adapter

On 2/11/23 5:42 PM, Ondrej Zary wrote:

> Only bpck driver uses devtype but it never gets set in pata_parport.
> Remove it.
> 
> Signed-off-by: Ondrej Zary <linux@...y.sk>
> ---
>  drivers/ata/pata_parport/bpck.c | 2 +-
>  include/linux/pata_parport.h    | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> index b9174cf8863c..451a068fe28a 100644
> --- a/drivers/ata/pata_parport/bpck.c
> +++ b/drivers/ata/pata_parport/bpck.c
> @@ -241,7 +241,7 @@ static void bpck_connect ( PIA *pi  )
>  
>  	WR(5,8);
>  
> -	if (pi->devtype == PI_PCD) {
> +	if (1 /*pi->devtype == PI_PCD*/) {	/* FIXME */
>  		WR(0x46,0x10);		/* fiddle with ESS logic ??? */

   Why not drop this entire *if* stmt? 

>  		WR(0x4c,0x38);
>  		WR(0x4d,0x88);
[...]

MBR, Sergey