linux-kernel - Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Feb 2023 00:01:27 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     linux-watchdog@...r.kernel.org,
        Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-kernel@...r.kernel.org, Wolfram Sang <wsa@...nel.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Grant Likely <grant.likely@...aro.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's
 .probe_new()

Hello,

On Fri, Jan 27, 2023 at 11:32:04AM +0100, Uwe Kleine-König wrote:
> On Fri, Nov 18, 2022 at 02:57:47PM -0800, Guenter Roeck wrote:
> > On Fri, Nov 18, 2022 at 11:45:30PM +0100, Uwe Kleine-König wrote:
> > > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > > 
> > > The probe function doesn't make use of the i2c_device_id * parameter so it
> > > can be trivially converted.
> > > 
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
> This patch hasn't made it into next yet. Is it still on your radar?
> 
> My plans for this series is to complete the conversion after the next
> merge window which should include most patches from this series.
> 
> So I ask you to either take this patch during the next merge window or
> accept that it will be applied together with the i2c core conversion
> that drops .probe() with the i2c_device_id parameter.

This got Guenter's R-b tag twice now, but the patch didn't appear yet in
next. I'll prepare a series for Wolfram to apply via his i2c tree based
on what is in next during the merge window with the idea to get the
change early into next with an immutable tag. If you get this patch in
during the merge window that would be ideal, but if not, I will take
care of it and as announced will send it together with the i2c change.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)