linux-kernel - Re: [PATCH 1/2] dt-bindings: arm: sti: addition of STi platform syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+lHiZRDH9brl3FR@imac101>
Date:   Sun, 12 Feb 2023 21:09:45 +0100
From:   Alain Volmat <avolmat@...com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Patrice Chotard <patrice.chotard@...s.st.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: sti: addition of STi platform
 syscon

Thanks for the review.

On Sun, Feb 12, 2023 at 05:00:24PM +0100, Krzysztof Kozlowski wrote:
> Thank you for your patch. There is something to discuss/improve. Few nits.
> 
> On 11/02/2023 22:04, Alain Volmat wrote:
> > Addition of the various STi platform syscon node description.
> 
> Use imperative.
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> 
> > 
> > Signed-off-by: Alain Volmat <avolmat@...com>
> > ---
> >  .../bindings/arm/sti/st,sti-syscon.yaml       | 46 +++++++++++++++++++
> >  1 file changed, 46 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> > new file mode 100644
> > index 000000000000..e4bbc90694b3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics STi platform sysconfig entries
> 
> 
> Drop "entries", does not look related to hardware.
> 
> > +
> > +maintainers:
> > +  - Patrice Chotard <patrice.chotard@...s.st.com>
> > +
> > +description: |
> > +  Binding for the various sysconfig nodes used within the STi
> > +  platform device-tree to point to some common configuration
> > +  registers used by other nodes.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - st,stih407-sbc-syscfg
> > +          - st,stih407-front-syscfg
> > +          - st,stih407-rear-syscfg
> > +          - st,stih407-flash-syscfg
> > +          - st,stih407-sbc-reg-syscfg
> > +          - st,stih407-core-syscfg
> > +          - st,stih407-lpm-syscfg
> 
> How about putting them in some order?

Ok, changed to alphabet order

> 
> > +      - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    syscfg_sbc: sbc-syscfg@...0000 {
> 
> Generic node names, thus usually syscon or system-controller

Ok, changed to syscfg_sbc: syscon@...0000

I also move the file within bindings/soc/sti as mentioned in your other
reply.

> > +...
> 
> Best regards,
> Krzysztof
>