linux-kernel - Re: [PATCH] get_maintainer: add email addresses from dts files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b82c782ee8c789a0bdc702526fd993952cabb6a2.camel@perches.com>
Date:   Sun, 12 Feb 2023 13:13:19 -0800
From:   Joe Perches <joe@...ches.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH] get_maintainer: add email addresses from dts files

On Sun, 2023-02-12 at 16:51 +0100, Krzysztof Kozlowski wrote:
> On 11/02/2023 17:27, Joe Perches wrote:
> > On Sat, 2023-02-11 at 13:14 +0100, Krzysztof Kozlowski wrote:
> > > The DTS/DTSI files represent hardware description for Linux kernel,
> > > which is necessary to properly recognize and configure hardware by
> > > Linux.  DTS is usually created by people having the actual hardware and
> > > having interest in keeping it in good shape.  Such people can provide
> > > review (they might have board schematics) and testing.  Unfortunately
> > > they mostly do not appear in MAINTAINERS file.  Adding per-DTS entries
> > > to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS
> > > entries).
> > > 
> > > On the other hand there is no point in CC-ing every Copyright email
> > > appearing in files, because it might be outdated.

That's what .mailmap is for.

> > > Add new in-file
> > > pattern for storing maintainers dedicated to specific boards:

I think adding Maintainer: who <who@....tld>

to each dts and dtsi file would be a lot of unnecessary changes
$ git ls-files | grep -P '\.dtsi?$' | wc -l
4673

> > > This is rework of earlier approach:
> > > Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@kernel.org
> > 
> > Why the rework?  I think the older one is much simpler.
> > 
> > I believe I forwarded the older one to Andrew Morton awhile back.
> > I'll check to see what happened to it.
> 
> It was never merged, thus I assumed some changes are needed, e.g. to
> ignore emails in copyrights.

I think the old one is fine.