linux-kernel - Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 12 Feb 2023 23:56:46 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        thierry.reding@...il.com, jonathanh@...dia.com,
        oder_chiou@...ltek.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, lgirdwood@...il.com, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk()


Hi Sameer

> > Simple-card/audio-graph-card both are using asoc_simple_hw_params,
> > and it calls clk_set_rate() for Codec/CPU if it has mclk.
> > But am I misunderstanding ?
> > If it was simple-card-utils side miss, I'm happy to fix it.
> 
> The simple-card-utils driver does not populate the clock handle whenever 
> the MCLK clock is parsed from CODEC device node. So 
> asoc_simple_set_clk_rate() will not update the rate and clock 
> enable/disable won't happen either.Initially I had tried to fix this in 
> the simple-card-utils itself and it did break few things on other HW.
> Please see [0] for relevant discussion.
> 
> Later [1] was pushed to address the issue I was facing that time.
> 
> In summary, the suggestion was, clock property should be associated with 
> only devices and device driver should own up the clock handling for it. 
> The machine driver can just pass the required configuration for it.

Thank you for explanation about your issue,
I think I could understand it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto