linux-kernel - Re: [PATCH 3/3] HID: apple-magic-backlight: Add driver for keyboard backlight on internal Magic Keyboards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BM1PR01MB09311C6B533B156B66ED58C7B8DC9@BM1PR01MB0931.INDPRD01.PROD.OUTLOOK.COM>
Date:   Sun, 12 Feb 2023 05:16:23 +0000
From:   Aditya Garg <gargaditya08@...e.com>
To:     Pavel Machek <pavel@....cz>
CC:     Jiri Kosina <jikos@...nel.org>,
        "jkosina@...e.cz" <jkosina@...e.cz>,
        "benjamin.tissoires@...hat.com" <benjamin.tissoires@...hat.com>,
        Andy Shevchenko <andy@...radead.org>,
        "andy.shevchenko@...il.com" <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "ronald@...ovation.ch" <ronald@...ovation.ch>,
        "kekrby@...il.com" <kekrby@...il.com>,
        Orlando Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH 3/3] HID: apple-magic-backlight: Add driver for keyboard
 backlight on internal Magic Keyboards



> On 11-Feb-2023, at 10:26 PM, Pavel Machek <pavel@....cz> wrote:
> 
> Hi!
> 
>> From: Orlando Chamberlain <orlandoch.dev@...il.com>
>> 
>> This driver adds support for the keyboard backlight on Intel T2 Macs
>> with internal Magic Keyboards (MacBookPro16,x and MacBookAir9,1)
> 
>> +    backlight->hdev = hdev;
>> +    backlight->cdev.name = "apple::kbd_backlight";
> 
> ":white:kbd_backlight", plus document this in
> Documentation/leds/well-known-leds.txt so that we keep it consistent
> accross machines?

We had used the same name for butterfly keyboards, the code being in hid-apple

Will that also be needed to be changed?

> 
> Thanks,
>                                        Pavel
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.