linux-kernel - Re: [PATCH V2 net-next] net: fec: add CBS offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+pjl3vzi7TQcLKm@lunn.ch>
Date:   Mon, 13 Feb 2023 17:21:43 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexander Lobakin <alexandr.lobakin@...el.com>
Cc:     wei.fang@....com, shenwei.wang@....com, xiaoning.wang@....com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, simon.horman@...igine.com,
        netdev@...r.kernel.org, linux-imx@....com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 net-next] net: fec: add CBS offload support

> > +	if (!speed) {
> > +		netdev_err(ndev, "Link speed is 0!\n");
> 
> ??? Is this possible? If so, why is it checked only here and why can it
> be possible?

The obvious way this happens is that there is no link partner, so
auto-neg has not completed yet. The link speed is unknown.

     Andrew