linux-kernel - RE: drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5884ba04b5364eab9c875139fa1f408b@realtek.com>
Date:   Mon, 13 Feb 2023 00:57:08 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Dan Carpenter <error27@...il.com>,
        "oe-kbuild@...ts.linux.dev" <oe-kbuild@...ts.linux.dev>
CC:     "lkp@...el.com" <lkp@...el.com>,
        "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kalle Valo <kvalo@...nel.org>
Subject: RE: drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu_status() warn: missing error code? 'ret'

Hi,

> -----Original Message-----
> From: Dan Carpenter <error27@...il.com>
> Sent: Saturday, February 11, 2023 12:11 AM
> To: oe-kbuild@...ts.linux.dev; Ping-Ke Shih <pkshih@...ltek.com>
> Cc: lkp@...el.com; oe-kbuild-all@...ts.linux.dev; linux-kernel@...r.kernel.org; Kalle Valo
> <kvalo@...nel.org>
> Subject: drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu_status() warn: missing error
> code? 'ret'
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   e544a07438522ab3688416e6e2e34bf0ee6d8755
> commit: 7ba49f4c6896d83b3841c0b046a0a7b1e97cc0dd rtw89: 8852c: add 8852ce to Makefile and Kconfig
> config: parisc-randconfig-m031-20230209
> (https://download.01.org/0day-ci/archive/20230210/202302101023.ctlih5q0-lkp@intel.com/config)
> compiler: hppa-linux-gcc (GCC) 12.1.0
> 
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Dan Carpenter <error27@...il.com>
> | Link: https://lore.kernel.org/r/202302101023.ctlih5q0-lkp@intel.com/
> 
> smatch warnings:
> drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu_status() warn: missing error code? 'ret'
> 
> vim +/ret +3829 drivers/net/wireless/realtek/rtw89/mac.c
> 
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3818  int rtw89_mac_cfg_ppdu_status(struct rtw89_dev *rtwdev, u8
> mac_idx, bool enable)
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3819  {
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3820  	u32 reg = rtw89_mac_reg_by_idx(R_AX_PPDU_STAT, mac_idx);
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3821  	int ret = 0;
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3822
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3823  	ret = rtw89_mac_check_mac_en(rtwdev, mac_idx,
> RTW89_CMAC_SEL);
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3824  	if (ret)
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3825  		return ret;
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3826
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3827  	if (!enable) {
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11  3828  		rtw89_write32_clr(rtwdev, reg,
> B_AX_PPDU_STAT_RPT_EN);
> e3ec7017f6a20d Ping-Ke Shih  2021-10-11 @3829  		return ret;
> 
> The code is correct, but it would be more readable to return 0;

Yes, it will be more readable. I will send a patch to change them soon.
Thanks for pointing out this.

Ping-Ke