linux-kernel - Re: [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y+p6mY+w9POvkBzC@smile.fi.intel.com>
Date:   Mon, 13 Feb 2023 19:59:53 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Raul Rangel <rrangel@...omium.org>
Cc:     Werner Sembach <wse@...edocomputers.com>,
        Mario Limonciello <mario.limonciello@....com>,
        mika.westerberg@...ux.intel.com, linus.walleij@...aro.org,
        brgl@...ev.pl, linux-gpio@...r.kernel.org,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alex Deucher <alexander.deucher@....com>
Subject: Re: [PATCH] gpiolib: acpi: Add a ignore wakeup quirk for Clevo NH5xAx

On Mon, Feb 13, 2023 at 07:57:55PM +0200, Andy Shevchenko wrote:
> On Mon, Feb 13, 2023 at 07:50:02PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 13, 2023 at 10:20:41AM -0700, Raul Rangel wrote:
> > > On Mon, Feb 13, 2023 at 7:47 AM Werner Sembach <wse@...edocomputers.com> wrote:
> > > > Am 13.02.23 um 15:37 schrieb Andy Shevchenko:

...

> > > > Schematics for the NH5xAx can also be found on this unofficial clevo mirror
> > > > (service manuals, scroll to end for schematics):
> > > >
> > > > http://repo.palkeo.com/clevo-mirror/NH5xACx_AFx_ADx/NH50AC.zip
> > > >
> > > > http://repo.palkeo.com/clevo-mirror/NH5xACx_AFx_ADx/NH50AF1.zip
> > > >
> > > > User: repo
> > > >
> > > > PW: repo
> > > >
> > > > >> The schematics were shared by the reporter for the original issue which is
> > > > >> how we reached the conclusion there was a mistake.
> > > > >>
> > > > >> As they're both Clevo designs it's certainly possible they have the same
> > > > >> mistake in two systems.
> > > 
> > > > > Thank you!
> > > > > I have looked at the schematics and read discussion.
> > > > >
> > > > > So, the conclusion that this is a BIOS bug is incorrect in my opinion.
> > > > > The problem is either in the PMIC/EC firmware that shouldn't shut down 3.3VS
> > > > > signal for a while or on the PCB level, so that pull up should be connected
> > > > > to another power source that stays on.
> > > > >
> > > > > This means the description on the initial patch with the same issue is
> > > > > incorrect.
> > > > >
> > > > > Do we know the power sequence on the suspend to see which and how on the
> > > > > time line the power sources are off/on?
> > > 
> > > If you look at the load switch for 3.3VS, its EN2 pin is connected to
> > > SUSB#_EN which is connected to SUSB# which is connected to
> > > AND(SUSB#_PCH -> SLP_S3_L, PM_SLP_S0 -> S0A3_GPIO). So there is no
> > > PMIC/EC firmware that is incharge of this. I guess I'm not quite sure
> > > how they have S0A3_GPIO configured, so maybe I have an invert wrong.
> > > 
> > > The EC does control DD_ON which controls the 3.3V and 5V rails.
> > 
> > On page 6 of the schematics I see the U7 that forms SUSB# from SUSB#_APU
> > (which corresponds to what you said) _and_ EC_EN, which is GPIO from IT5570,
> > which is EC.
> > 
> > Are you using different schematics? I'm using the one from FDO bug report.
> 
> Just checked this one:
> http://repo.palkeo.com/clevo-mirror/NH5xACx_AFx_ADx/NH50AC.zip
> 
> Also uses EC (SUSB_EC#).

So this all makes me thing that either EC firmware is buggy or we have ACPI EC
code in the kernel to fix.

-- 
With Best Regards,
Andy Shevchenko