linux-kernel - Re: [PATCH] soc: apple: rtkit: Do not copy the reg state structure to the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <2c8a8539-649c-47d2-b416-6d607cba5956@app.fastmail.com>
Date:   Mon, 13 Feb 2023 20:22:28 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Eric Curtin" <ecurtin@...hat.com>,
        "Asahi Lina" <lina@...hilina.net>
Cc:     "Hector Martin" <marcan@...can.st>,
        "Sven Peter" <sven@...npeter.dev>,
        "Alyssa Rosenzweig" <alyssa@...enzweig.io>, asahi@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: apple: rtkit: Do not copy the reg state structure to the
 stack

On Mon, Feb 13, 2023, at 18:15, Eric Curtin wrote:
> On Sat, 11 Feb 2023 at 09:21, Asahi Lina <lina@...hilina.net> wrote:
>>
>> The register state struct is 848 bytes, which ends up bloating the
>> apple_rtkit_crashlog_dump_regs stack frame beyond 1024 on some
>> 32-bit platforms, triggering compile warnings.
>>
>> This doesn't matter for 64BIT/ARM64, but there's also no good reason to
>> copy the structure to the stack in this case. We can use __packed to
>> avoid alignment issues, there are no double-read hazards, and this is a
>> fatal error path so performance does not matter.
>>
>> Fixes: 22991d8d5725 ("soc: apple: rtkit: Add register dump decoding to crashlog")
>> Signed-off-by: Asahi Lina <lina@...hilina.net>
> Reviewed-by: Eric Curtin <ecurtin@...hat.com>

Merged now, thanks a lot for the fix!

     Arnd